1738855 - the border of the active tab has changed

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Sören Hentzschel]

Attachment: screenshot

Bug 1734128 changed the border of the active tab - at least on macOS where I tested. Since there is no mention of a design change in bug 1734128 and bug 1734128 only talks about Windows 10 I guess it was not an intentional change. I attached a screenshot for comparison. It was tested on the default Firefox theme without any customization on a MacBook Pro with macOS 11 and the default scaling (but the screenshot has a 200% zoom).

Comment 1

[Amy Churchwell [:amy]]

Thank you for filing this! Apologies, an unfortunate side effect of moving away from box-shadow. I believe we can safely update the color of tab_line in the light theme manifest to be a lighter shade to closer resemble what we originally had.

Comment 2

[Amy Churchwell [:amy]]

Attachment: Bug 1738855 - restore light theme active tab styles. r?dao,harry

Comment 4

[Mehmet]

The regression caused this dark border in Light Mode and probably in Dark Mode a vertically shrinked tab (see bug 1740788.)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c4174c4969c
restore light theme active tab styles. r=dao

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5c4174c4969c

Comment 8

[Mehmet]

Hello Amy,

Unfortunately this isn't fixed completely, at least on macOS and Nightly 96.0a1 (2021-11-19) (64-Bit).

There is still a strange bug:

When I am in macOS System Light Mode and have Nightly's System Theme Depended Color selected, then the dark border still appears around the active tab.

It is fixed, (no dark border appears), when I explicit select Nightly's Light Theme.

Can you please take a look? Thanks in advance.

Comment 9

[Mehmet]

Attachment: Still_Dark_Border_with_System_Theme.png

Comment 10

[Mehmet]

Attachment: No_Dark_Border_with_Light_Theme.png

Comment 11

[Dão Gottwald [:dao]]

(In reply to Mehmet from comment #8)

There is still a strange bug:

When I am in macOS System Light Mode and have Nightly's System Theme Depended Color selected, then the dark border still appears around the active tab.

Bug 1740788 fixes this.

Comment 12

[Mehmet]

(In reply to Dão Gottwald [::dao] from comment #11)

(In reply to Mehmet from comment #8)

There is still a strange bug:

When I am in macOS System Light Mode and have Nightly's System Theme Depended Color selected, then the dark border still appears around the active tab.

Bug 1740788 fixes this.

Great! Many thanks for your feedback.

Comment 13

[Sören Hentzschel]

Attachment: screenshot

Even after bug 1740788 the border is still much darker than before on macOS. And since it's darker the clipped shadow (on the left side; a pre-existing issue) is much more noticeable.

Comment 14

[Mehmet]

(In reply to Sören Hentzschel from comment #13)

Created attachment 9251786 [details]
screenshot

Even after bug 1740788 the border is still much darker than before on macOS. And since it's darker the clipped shadow (on the left side; a pre-existing issue) is much more noticeable.

Hi, yes, I noticed this too and opened bug 1742239 yesterday.

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Closing this as verified and removing qe+ flag given the fact that the remaining issue will be fixed in bug 1742239 per comment 23. Tested on macOS 10.15 with Firefox 96.0b4.