Closed Bug 1739007 Opened 3 years ago Closed 2 years ago

isEnabled checks remote default before experiment variable enabled value

Categories

(Firefox :: Nimbus Desktop Client, defect)

Product:
Firefox
Component:
Nimbus Desktop Client
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: Mardak, Unassigned, NeedInfo)

References

Details

https://searchfox.org/mozilla-central/rev/7588d077255c5732f72c466e71d7a38d97385dd5/toolkit/components/nimbus/ExperimentAPI.jsm#415,423,427,433

Recently feature.enabled and "enabled" UI toggle got removed from nimbus. This now requires feature variable {enabled: false} to be set to disable. However, remote defaults record has higher precedence than getVariable.

Testing with https://experimenter.services.mozilla.com/nimbus/mr2-upgrade-spotlight-holdback-copy treatment branch resulted in…

NimbusFeatures.upgradeDialog.isEnabled()
true
NimbusFeatures.upgradeDialog.getVariable("enabled")
false

This should be covered by bug 1738286.

See Also: → 1739525

The severity field is not set for this bug.
:k88hudson, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(khudson)
Depends on: 1738286

Rollouts now do not take priority over experiments, so I'm closing this.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.