`feature.enabled` is still in use even when server already removed it
Categories
(Firefox :: Nimbus Desktop Client, defect)
Tracking
()
People
(Reporter: Mardak, Unassigned)
References
Details
Similar to bug 1739007 with functionality broken with the removal of feature.enabled, there's some other code still relying on it such as ASRouter exposure ping:
There may be other existing uses of the direct object property access instead of using the isEnabled() wrapper. But even with isEnabled(), that assumes correct experiment feature value configuration with setting {enabled: true}
|
||
Updated•3 years ago
|
|
Reporter | |
Comment 1•3 years ago
|
||
Actually, without feature.enabled I believe even treatment branch that set it to true will be treated as disabled because server no longer sets that value. This affects https://experimenter.services.mozilla.com/nimbus/emotive-pin-firefox-modal/details as the experiment hasn't ended enrollment, but doing so will remove feature.enabled from remote settings record breaking all the treatment branches.
|
|
Reporter | |
Comment 2•3 years ago
|
||
Bug 1739666 might specifically fix the issue from comment 0, so this bug might be a dupe… unless there are still other usages of feature.enabled elsewhere.
|
|
Reporter | |
Comment 3•3 years ago
|
||
Server is reverting the feature.enabled removal with https://github.com/mozilla/experimenter/pull/6631
Description
•