1998657 - [Wayland] Allow to paint to offscreen surface before map

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

[Wayland] Allow to paint to offscreen surface before map.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It means to remove moz_container_wayland_is_waiting_to_show() and WaylandSurface::mIsReadyToDraw which should be always true.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Wayland] Make WaylandSurface ready to draw right after its created r?emilio

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Wayland] Create EGLWindow over offscreen wl_surface and make it always available r?emilio

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Let's land it in next cycle, after freeze.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=162763

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b39b0ef973df
https://hg.mozilla.org/integration/autoland/rev/e423b6493306
[Wayland] Make WaylandSurface ready to draw right after its created r=emilio
https://github.com/mozilla-firefox/firefox/commit/de6ac364421c
https://hg.mozilla.org/integration/autoland/rev/3d23ba5d4bf6
[Wayland] Create EGLWindow over offscreen wl_surface and make it always available r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f5f68709dddc
https://hg.mozilla.org/integration/autoland/rev/094757ccd72d
Revert "Bug 1998657 [Wayland] Create EGLWindow over offscreen wl_surface and make it always available r=emilio" for causing valgrind failures

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing valgrind failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/094757ccd72d8672311de6aebab5e4611d9505e4

Push with failures

Failure log

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Thanks, will look at it.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

We need to update the memleak check for different signature:
https://searchfox.org/firefox-main/rev/c82adde571c24d89da3ef13f11245c8f572ba1e6/build/valgrind/x86_64-pc-linux-gnu.sup#261
It's a bug in Gtk3.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Linux] Update gdk_x11 window resource leak as GdkWindow is created from nsWindow::Create() r?emilio

Comment 12

[s.zharkoff]

applied those patches over autoland and bookmarks menus (second level - wheh hoovering over folder ) disappeared again.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c2d08fd134f4
https://hg.mozilla.org/integration/autoland/rev/f38b48f473af
[Wayland] Make WaylandSurface ready to draw right after its created r=emilio
https://github.com/mozilla-firefox/firefox/commit/114cfcb1e4d0
https://hg.mozilla.org/integration/autoland/rev/4b375c234df0
[Wayland] Create EGLWindow over offscreen wl_surface and make it always available r=emilio
https://github.com/mozilla-firefox/firefox/commit/e71ec995b1bb
https://hg.mozilla.org/integration/autoland/rev/140faab7b8ed
[Linux] Update gdk_x11 window resource leak as GdkWindow is created from nsWindow::Create() r=emilio

Comment 14

[Martin Stránský [:stransky] (ni? me)]

(In reply to s.zharkoff from comment #12)

applied those patches over autoland and bookmarks menus (second level - wheh hoovering over folder ) disappeared again.

Will look at it, Thanks.

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f38b48f473af
https://hg.mozilla.org/mozilla-central/rev/4b375c234df0
https://hg.mozilla.org/mozilla-central/rev/140faab7b8ed

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/89b2affdc5d2
https://hg.mozilla.org/integration/autoland/rev/338a6e3364af
Revert "Bug 1998657 [Linux] Update gdk_x11 window resource leak as GdkWindow is created from nsWindow::Create() r=emilio" for causing various crashes

Comment 17

[amarc]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/338a6e3364af

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Thanks. The regressions here are caused by removed ready-to-draw callback. It was replaced by regular callback & mIsVisible but we don't actually register VSync handlers / frame callbacks for popups so we're missing the state then for popups.

Comment 19

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Wayland] Update fractional scale & popup logging r?emilio

Comment 20

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Wayland] Set mIsVisible from frame callback r?emilio

Comment 21

[Martin Stránský [:stransky] (ni? me)]

I hit another possible regression / crash when toplevel window is detached to a new one by D&D. Investigating now.

Comment 22

[Martin Stránský [:stransky] (ni? me)]

Looks like we need to set / remove mGdkWindow by moz_container_realize / moz_container_unrealize where it's created/deleted.

Comment 23

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Linux] Set/Unset mGdkWindow on container realize/unrealize to make sure we have recent GdkWindow r?emilio

Comment 24

[Martin Stránský [:stransky] (ni? me)]

There's one missing piece here - As mGdkWindow can be null (between unrealize/realize call) we may partially revert !mGdkWindow conditions from https://phabricator.services.mozilla.com/D271773 and investigate wl_surface usage derived from mGdkWindow/mContainer. AFAIK this change may affects D&D popups and titlebar on/off switch from customize.

D&D popup uses SW drawing to cairo surface derived from GtkWidget so we should be safe here. Titlebar on/off code preserves mContainer and realize/unrealize mShell only:
https://searchfox.org/firefox-main/rev/3728e0c87fc4fa87ddf0c7a8183f2dd2329be96a/widget/gtk/nsWindow.cpp#9149

But we should investigate these cases and put appropriate asserts there.

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/915de2a8936a
https://hg.mozilla.org/integration/autoland/rev/13531e6d7800
[Wayland] Make WaylandSurface ready to draw right after its created r=emilio
https://github.com/mozilla-firefox/firefox/commit/6cb5ce2f04df
https://hg.mozilla.org/integration/autoland/rev/8d2c2eed0ae9
[Wayland] Create EGLWindow over offscreen wl_surface and make it always available r=emilio
https://github.com/mozilla-firefox/firefox/commit/51937e8e4515
https://hg.mozilla.org/integration/autoland/rev/ab4b6522b172
[Linux] Update gdk_x11 window resource leak as GdkWindow is created from nsWindow::Create() r=emilio
https://github.com/mozilla-firefox/firefox/commit/1997d8a78dcd
https://hg.mozilla.org/integration/autoland/rev/894dbdde0d67
[Wayland] Update fractional scale & popup logging r=emilio
https://github.com/mozilla-firefox/firefox/commit/7cf41c4eb161
https://hg.mozilla.org/integration/autoland/rev/12fb9984f683
[Wayland] Set mIsVisible from frame callback r=emilio
https://github.com/mozilla-firefox/firefox/commit/3a006d1c8f2a
https://hg.mozilla.org/integration/autoland/rev/1ca35d1f2d48
[Linux] Set/Unset mGdkWindow on container realize/unrealize to make sure we have recent GdkWindow r=jhorak

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b73e692a64e8
https://hg.mozilla.org/integration/autoland/rev/5068fbe918fa
Revert "Bug 1998657 [Linux] Set/Unset mGdkWindow on container realize/unrealize to make sure we have recent GdkWindow r=jhorak" for causing bustages at WaylandSurface.cpp.

Comment 27

[Atila Butkovits]

Backed out for causing bustages at WaylandSurface.cpp.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/5068fbe918fa116948457aed600f93901916ab8f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1ca35d1f2d48af5c346332740767168ac5b1d223&selectedTaskRun=PmcHJuR8SuKchR08ikQCWQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=536616766&repo=autoland&task=PmcHJuR8SuKchR08ikQCWQ.0&lineNumber=103318

Comment 28

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a0d567ff3daa
https://hg.mozilla.org/integration/autoland/rev/56d739c47a29
[Wayland] Make WaylandSurface ready to draw right after its created r=emilio
https://github.com/mozilla-firefox/firefox/commit/65ab92784908
https://hg.mozilla.org/integration/autoland/rev/34254848c695
[Wayland] Create EGLWindow over offscreen wl_surface and make it always available r=emilio
https://github.com/mozilla-firefox/firefox/commit/e03e557a6033
https://hg.mozilla.org/integration/autoland/rev/b6c8a8b3ccc3
[Linux] Update gdk_x11 window resource leak as GdkWindow is created from nsWindow::Create() r=emilio
https://github.com/mozilla-firefox/firefox/commit/0de0fe7b26f4
https://hg.mozilla.org/integration/autoland/rev/1a8f93c5ffe1
[Wayland] Update fractional scale & popup logging r=emilio
https://github.com/mozilla-firefox/firefox/commit/a383a1fc3258
https://hg.mozilla.org/integration/autoland/rev/d5eec9e18b63
[Wayland] Set mIsVisible from frame callback r=emilio
https://github.com/mozilla-firefox/firefox/commit/d8886e6742df
https://hg.mozilla.org/integration/autoland/rev/1507c17888dc
[Linux] Set/Unset mGdkWindow on container realize/unrealize to make sure we have recent GdkWindow r=jhorak

Comment 30

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/56d739c47a29
https://hg.mozilla.org/mozilla-central/rev/34254848c695
https://hg.mozilla.org/mozilla-central/rev/b6c8a8b3ccc3
https://hg.mozilla.org/mozilla-central/rev/1a8f93c5ffe1
https://hg.mozilla.org/mozilla-central/rev/d5eec9e18b63
https://hg.mozilla.org/mozilla-central/rev/1507c17888dc