1998657 - [Wayland] Allow to paint to offscreen surface before map

Status: REOPENED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

[Wayland] Allow to paint to offscreen surface before map.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It means to remove moz_container_wayland_is_waiting_to_show() and WaylandSurface::mIsReadyToDraw which should be always true.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Wayland] Make WaylandSurface ready to draw right after its created r?emilio

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Wayland] Create EGLWindow over offscreen wl_surface and make it always available r?emilio

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Let's land it in next cycle, after freeze.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=162763

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b39b0ef973df
https://hg.mozilla.org/integration/autoland/rev/e423b6493306
[Wayland] Make WaylandSurface ready to draw right after its created r=emilio
https://github.com/mozilla-firefox/firefox/commit/de6ac364421c
https://hg.mozilla.org/integration/autoland/rev/3d23ba5d4bf6
[Wayland] Create EGLWindow over offscreen wl_surface and make it always available r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f5f68709dddc
https://hg.mozilla.org/integration/autoland/rev/094757ccd72d
Revert "Bug 1998657 [Wayland] Create EGLWindow over offscreen wl_surface and make it always available r=emilio" for causing valgrind failures

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing valgrind failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/094757ccd72d8672311de6aebab5e4611d9505e4

Push with failures

Failure log

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Thanks, will look at it.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

We need to update the memleak check for different signature:
https://searchfox.org/firefox-main/rev/c82adde571c24d89da3ef13f11245c8f572ba1e6/build/valgrind/x86_64-pc-linux-gnu.sup#261
It's a bug in Gtk3.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1998657 [Linux] Update gdk_x11 window resource leak as GdkWindow is created from nsWindow::Create() r?emilio

Comment 12

[s.zharkoff]

applied those patches over autoland and bookmarks menus (second level - wheh hoovering over folder ) disappeared again.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c2d08fd134f4
https://hg.mozilla.org/integration/autoland/rev/f38b48f473af
[Wayland] Make WaylandSurface ready to draw right after its created r=emilio
https://github.com/mozilla-firefox/firefox/commit/114cfcb1e4d0
https://hg.mozilla.org/integration/autoland/rev/4b375c234df0
[Wayland] Create EGLWindow over offscreen wl_surface and make it always available r=emilio
https://github.com/mozilla-firefox/firefox/commit/e71ec995b1bb
https://hg.mozilla.org/integration/autoland/rev/140faab7b8ed
[Linux] Update gdk_x11 window resource leak as GdkWindow is created from nsWindow::Create() r=emilio

Comment 14

[Martin Stránský [:stransky] (ni? me)]

(In reply to s.zharkoff from comment #12)

applied those patches over autoland and bookmarks menus (second level - wheh hoovering over folder ) disappeared again.

Will look at it, Thanks.

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f38b48f473af
https://hg.mozilla.org/mozilla-central/rev/4b375c234df0
https://hg.mozilla.org/mozilla-central/rev/140faab7b8ed

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/89b2affdc5d2
https://hg.mozilla.org/integration/autoland/rev/338a6e3364af
Revert "Bug 1998657 [Linux] Update gdk_x11 window resource leak as GdkWindow is created from nsWindow::Create() r=emilio" for causing various crashes

Comment 17

[amarc]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/338a6e3364af