Closed Bug 1739289 Opened 3 months ago Closed 1 month ago

Remove or update probes expiring in Firefox 97: os.environment.is_kept_in_dock

Categories

(Firefox :: Messaging System, task, P2)

task

Tracking

()

VERIFIED FIXED
97 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox95 --- unaffected
firefox96 --- unaffected
firefox97 --- verified

People

(Reporter: telemetry-probes, Assigned: mviar)

References

Details

(Keywords: good-first-bug, Whiteboard: [probe-expiry-alert])

Attachments

(5 files)

The following Firefox probes will expire in the next major Firefox nightly release: version 97 [1].

os.environment.is_kept_in_dock

What to do about this:

  1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
  2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Flags: needinfo?(shong)
Flags: needinfo?(akmathur)

Should get product feedback (@akmathur) to decide if this matrix should be forever for both Mac and Windows.

The windows os.environment.is_taskbar_pinned (as well as os.environment.launch_method) were bumped up to Fx100 in bug 1725298.

See Also: → 1725298

Got update from @akmathur , product would like to keep this telemetry permanently. To fix we should remove expire flag from respective probes inside scalars.yaml and submit for data-review. See Bug 1725298

https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Scalars.yaml#1856

Flags: needinfo?(akmathur)
Keywords: good-first-bug
Priority: -- → P2
Assignee: nobody → mviar
Status: NEW → ASSIGNED
Attached file renewal_request.md
Attachment #9253931 - Flags: data-review?(jhirsch)

Updated with initial review for pinned to taskbar.

Attachment #9253948 - Flags: data-review?(jhirsch)
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3045df4ba610
Disable test_browserGlue_newwindow_restriction_telemetry.js for causing permafailures after m-c version was increased. a=test-only
https://hg.mozilla.org/integration/autoland/rev/d9faec106738
Disable browser_browserGlue_telemetry.js for permafailing after m-c version was increased. a=test-only

Disabled test_browserGlue_newwindow_restriction_telemetry.js and browser_browserGlue_telemetry.js while they are being fixed for causing multiple failures on nightly.

See Also: → 1744591
See Also: → 1744667
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/3832261ad6c2
Disable test_browserGlue_newwindow_restriction_telemetry.js for causing permafailures after m-c version was increased. a=test-only
https://hg.mozilla.org/mozilla-central/rev/592ce8e18548
Disable browser_browserGlue_telemetry.js for permafailing after m-c version was increased. a=test-only
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 97 Branch → ---
Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch

We should be able to un-skip the tests when landing the expires: never

Status: RESOLVED → REOPENED
Flags: needinfo?(shong)
Resolution: FIXED → ---
Target Milestone: 97 Branch → ---
Attachment #9253931 - Flags: data-review?(jhirsch)
Attachment #9253948 - Flags: data-review?(jhirsch) → data-review?(chutten)

Comment on attachment 9253948 [details]
updated_renewal_request.md

The Data Request Renewal short form can only be used to renew to another expiry. Making a probe permanent requires the use of the full form as there are some pieces of information (notably the person responsible for the probe over time) that only the full form has.

Attachment #9253948 - Flags: data-review?(chutten) → data-review-

@akmathur - I've listed you under #7 as the person responsible for the probe per @mardak's comments.

Attachment #9254542 - Flags: data-review?(chutten)
Attachment #9254542 - Flags: checkin?(akmathur)

@akmathur - Same as in the one above, I've listed you under #7 as the person responsible for the probe.

Attachment #9254543 - Flags: data-review?(chutten)
Attachment #9254543 - Flags: checkin?(akmathur)

Comment on attachment 9254543 [details]
Data Review Request Form - is_taskbar_pinned.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Akash Mathur is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9254543 - Flags: data-review?(chutten) → data-review+

Comment on attachment 9254542 [details]
Data Review Request Form - is_kept_in_dock.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Akash Mathur is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9254542 - Flags: data-review?(chutten) → data-review+
Pushed by mviar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b554dfb7a9cb
Remove or update probes expiring in Firefox 97: os.environment.is_kept_in_dock r=Mardak
Status: REOPENED → RESOLVED
Closed: 2 months ago1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch

I have verified this issue using the latest Firefox Nightly 97.0a1 (Build ID: 20211219214917) on Windows 10 x64 and macOS 11.6.

  • The “os.environment.is_kept_in_dock” scalar is registered on macOS and has the “true” value when the browser is kept in dock or the “false” value when the browser is not kept in dock.
  • The “os.environment.is_taskbar_pinned” scalar is registered on Windows OS and has the “true” value when the browser is pinned to Taskbar or the “false” value when the browser is not pinned.
Status: RESOLVED → VERIFIED
Attachment #9254542 - Flags: checkin?(akmathur)
Attachment #9254543 - Flags: checkin?(akmathur)
You need to log in before you can comment on or make changes to this bug.