Closed Bug 1744591 Opened 6 months ago Closed 6 months ago

Permafailing browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js | xpcshell return code: 0

Categories

(Firefox :: General, defect, P5)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox95 --- unaffected
firefox96 --- fixed
firefox97 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: arai)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1744591 - Stop collecting telemetry for hidden browser.link.open_newwindow.restriction preference usage. r?chutten!
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
pascalc
: approval-mozilla-release-
Details | Review

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=360279673&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LrZGWSItRZyVNInkpj0tZg/runs/0/artifacts/public/logs/live_backing.log

[task 2021-12-06T20:13:01.532Z] 20:13:01     INFO -  TEST-START | browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js
[task 2021-12-06T20:13:02.004Z] 20:13:02  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js | xpcshell return code: 0
[task 2021-12-06T20:13:02.004Z] 20:13:02     INFO -  TEST-INFO took 471ms
[task 2021-12-06T20:13:02.004Z] 20:13:02     INFO -  >>>>>>>
[task 2021-12-06T20:13:02.006Z] 20:13:02     INFO -  PID 30174 | [Parent 30174, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2964
[task 2021-12-06T20:13:02.007Z] 20:13:02     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-12-06T20:13:02.007Z] 20:13:02     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-12-06T20:13:02.007Z] 20:13:02     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-12-06T20:13:02.008Z] 20:13:02     INFO -  running event loop
[task 2021-12-06T20:13:02.008Z] 20:13:02     INFO -  PID 30174 | [Parent 30174, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, kKnownEsrVersion) failed with result 0x80004002 (NS_NOINTERFACE): file /builds/worker/checkouts/gecko/toolkit/components/resistfingerprinting/nsRFPService.cpp:560
[task 2021-12-06T20:13:02.009Z] 20:13:02     INFO -  browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js | Starting
[task 2021-12-06T20:13:02.009Z] 20:13:02     INFO -  (xpcshell/head.js) | test pending (2)
[task 2021-12-06T20:13:02.009Z] 20:13:02  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js |  - "undefined" == 0
[task 2021-12-06T20:13:02.010Z] 20:13:02     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js:null:27
[task 2021-12-06T20:13:02.010Z] 20:13:02     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_run_next_test/<:1674
[task 2021-12-06T20:13:02.010Z] 20:13:02     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_run_next_test:1674
[task 2021-12-06T20:13:02.010Z] 20:13:02     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:run:820
[task 2021-12-06T20:13:02.012Z] 20:13:02     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:240
[task 2021-12-06T20:13:02.012Z] 20:13:02     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:605
[task 2021-12-06T20:13:02.012Z] 20:13:02     INFO -  -e:null:1
[task 2021-12-06T20:13:02.012Z] 20:13:02     INFO -  exiting test
[task 2021-12-06T20:13:02.013Z] 20:13:02     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2021-12-06T20:13:02.013Z] 20:13:02     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2021-12-06T20:13:02.013Z] 20:13:02     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:876:20
[task 2021-12-06T20:13:02.013Z] 20:13:02     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:977:5
[task 2021-12-06T20:13:02.013Z] 20:13:02     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:75:21
[task 2021-12-06T20:13:02.014Z] 20:13:02     INFO -  proto.report@resource://testing-common/Assert.jsm:228:10
[task 2021-12-06T20:13:02.014Z] 20:13:02     INFO -  equal@resource://testing-common/Assert.jsm:270:8
[task 2021-12-06T20:13:02.014Z] 20:13:02     INFO -  @/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js:27:10
[task 2021-12-06T20:13:02.014Z] 20:13:02     INFO -  _run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1674:22
[task 2021-12-06T20:13:02.014Z] 20:13:02     INFO -  _run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1674:38
[task 2021-12-06T20:13:02.015Z] 20:13:02     INFO -  run@/builds/worker/workspace/build/tests/xpcshell/head.js:820:9
[task 2021-12-06T20:13:02.015Z] 20:13:02     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:240:6
[task 2021-12-06T20:13:02.015Z] 20:13:02     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:605:5
[task 2021-12-06T20:13:02.015Z] 20:13:02     INFO -  @-e:1:1
[task 2021-12-06T20:13:02.015Z] 20:13:02     INFO -  exiting test
[task 2021-12-06T20:13:02.016Z] 20:13:02     INFO -  PID 30174 | [Parent 30174, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3351
[task 2021-12-06T20:13:02.016Z] 20:13:02     INFO -  PID 30174 | [Parent 30174, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:3420
[task 2021-12-06T20:13:02.016Z] 20:13:02     INFO -  PID 30174 | [Parent 30174, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4439
[task 2021-12-06T20:13:02.016Z] 20:13:02     INFO -  PID 30174 | [Parent 30174, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:204
[task 2021-12-06T20:13:02.016Z] 20:13:02     INFO -  PID 30174 | [Parent 30174, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:204
[task 2021-12-06T20:13:02.017Z] 20:13:02     INFO -  <<<<<<<
[task 2021-12-06T20:13:02.020Z] 20:13:02     INFO -  TEST-START | extensions/pref/autoconfig/test/unit/test_autoconfig_nonascii.js

This has started permafailing after the version of mozilla central was increased from 96 to 97.

Dave, could you please take a look?

Flags: needinfo?(dtownsend)
Summary: Intermittent browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js | xpcshell return code: 0 → Permafailing browser/components/tests/unit/test_browserGlue_newwindow_restriction_telemetry.js | xpcshell return code: 0
Has Regression Range: --- → yes
See Also: → 1744596
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
See Also: → 1739289

Test was disabled in Bug 1739289 until the fix lands.

Flags: needinfo?(arai.unmht)
Blocks: 1744667
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/8a2b66a70bd7
Stop collecting telemetry for hidden browser.link.open_newwindow.restriction preference usage. r=chutten

https://hg.mozilla.org/mozilla-central/rev/8a2b66a70bd7

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox97: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch

Comment on attachment 9253987 [details]
Bug 1744591 - Stop collecting telemetry for hidden browser.link.open_newwindow.restriction preference usage. r?chutten!

Beta/Release Uplift Approval Request

  • User impact if declined: Unnecessary telemetry probe keeps working.

The telemetry probe was introduced by bug 1740063, to assist decision for bug 1714939 patch.
we got sufficient data for all channels, so it's fine removing the telemetry probe before it reaches the expiration.

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This just removes one telemetry probe
  • String changes made/needed:
Attachment #9253987 - Flags: approval-mozilla-release?
Attachment #9253987 - Flags: approval-mozilla-beta?

Comment on attachment 9253987 [details]
Bug 1744591 - Stop collecting telemetry for hidden browser.link.open_newwindow.restriction preference usage. r?chutten!

Approved for 96.0b6

Attachment #9253987 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9253987 - Flags: approval-mozilla-release? → approval-mozilla-release-
See Also: → 1749394
You need to log in before you can comment on or make changes to this bug.