1740070 - <select> elements aren't highlighted when previewing/autofilling credit card information

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Tim Giles [:tgiles]]

<select> options should have the same autofill coloring as other input elements when previewing and autofilling credit card information. After addressing this issue, we need to ensure that these forms are cleared and reset when using the "Clear form" option from the autocomplete dropdown.

This bug blocks any bug that mentions a <select> element not working correctly. The most common case is for credit card expiry dates, but could also be credit card type if type selection is implemented as a <select> element

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1740070 - Add tests to assert <select> elements are highlighted when they are autofilled. r=sgalich!,dimi

Comment 2

[Tim Giles [:tgiles]]

Attachment: Bug 1740070 - Reset <select> elements when autofilled form is cleared. r=sgalich!,dimi!

Depends on D133212

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1740070 - Highlight <select> elements when they are autofilled. r=tgiles

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc2769c714aa
Highlight <select> elements when they are autofilled. r=tgiles

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dc2769c714aa

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/401fb65f5474
Add tests to assert <select> elements are highlighted when they are autofilled. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/5117cef59635
Reset <select> elements when autofilled form is cleared. r=sgalich,dimi

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/401fb65f5474
https://hg.mozilla.org/mozilla-central/rev/5117cef59635

Comment 8

[Tim Giles [:tgiles]]

Now that the patches have landed, the bugs blocked by this should be ready for verification.

Comment 9

[Alin Ilea, Desktop Test Engineering]

Hi @tgiles,
We just verified all the blocked bugs by this one and you can find the current behavior for all of them in the last comment of each blocked bug.
Thanks and if you need any other information please let me know.

Comment 10

[Tim Giles [:tgiles]]

This is fixed now, the follow up issues are website specific issues.