1740407 - Illegible menu text when using theme add-on

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[custom.firefox.lady [:tawn]]

Steps to reproduce:

Enable a theme from https://addons.thunderbird.net (e.g. https://addons.thunderbird.net/en-US/thunderbird/addon/blue-285662-2/
but happens with every one I've tried)

Click an item on the menubar (e.g. Tools)

Actual results:

Inactive (grayed out) items do not appear at all (white on white?). Same thing happens with context menu of an item in the message list (e.g. 'Mark' submenu)

First noticed in 95b2; not 100% certain bug was not present prior to that version.

Expected results:

Inactive items should display as gray text on white background rather than being invisible/illegible.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1740407-LW-theme-inactive-menuitem.patch

In bug 1738604 I missed the inactive menu colour when using a dark LW-theme.

Comment 2

[Richard Marti (:Paenglab)]

Set the same tracking flags like bug 1738604.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9250280 [details] [diff] [review]
1740407-LW-theme-inactive-menuitem.patch

Review of attachment 9250280 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure why but these changes don't do anything for me.
I'm on Windows 11, not sure if it's related.

Comment 4

[Richard Marti (:Paenglab)]

You have a dark LW-theme, like Dark Fox, not the built-in dark theme and the light system theme?

Comment 5

[Alessandro Castellani [:aleca]]

Yes, I'm using the theme suggested by the reporter.

Comment 6

[custom.firefox.lady [:tawn]]

@ Marti (:Paenglab): Not on the Tbird beta computer with the issue ATM, but I can repro issue on Tbird release version if I apply info from regression patch via userChrome.css. And then similarly applying your fix, does indeed fix the issue. These are both on Windows 10.

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9250280 [details] [diff] [review]
1740407-LW-theme-inactive-menuitem.patch

Review of attachment 9250280 [details] [diff] [review]:
-----------------------------------------------------------------

It turns out, my windows artifact build environment was broken and it wasn't actually building anything.
I fixed it now and the patch applied works properly.
Good work.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ed02082b8df
[Windows 10] Set also an inactive menu color with dark LW-themes. r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9250280 [details] [diff] [review]
1740407-LW-theme-inactive-menuitem.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1738604
User impact if declined: with dark system theme and a dark LW-theme are the disabled menuitems unreadable
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, it's a one-liner with defining a CSS variable

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9250280 [details] [diff] [review]
1740407-LW-theme-inactive-menuitem.patch

[Triage Comment]
Approved for beta
Approved for esr91

Approved at same time based on comment 6

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.3.2:
https://hg.mozilla.org/releases/comm-esr91/rev/c35def313c0c

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 95.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/fa760725d72a