1742158 - Calendar printing not possible - maybe a regression by Bug 1724090

Status: VERIFIED FIXED

(Calendar :: Printing, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

In Thunderbird 91.3.2 it isn't possible to print calendars. Finally clicking the print button in the print dialog throws a javascript error in print.js in line 254:

Uncaught (in promise) TypeError: cancelButton is null
    init chrome://global/content/print.js:254
    handleEvent chrome://global/content/print.js:1665
print.js:254:1

STR:
Open a calendar tab.
Open the print dialog → Forward to 2nd page of print dialog → Click "Print".
Nothing happens / error is in console

It seems the JS code still refers to the "Cancel" button, which has been changed to the "Back" button in 91.3.2

Comment 1

[Rachel Martin]

https://github.com/Betterbird/thunderbird-patches/blob/main/91/bugs/1742158-calendar-print.patch

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

The provided patch states, that the buttons ID should be maintained: "We need to maintain the ID since M-C code refers to it."

IMHO we should restore the complete Cancel button and have the Back button as an additional 3rd button, if this would be possible in the dialog.

Reasons for this opinion:
*The confusion about IDs in JavaScript code because you are dependent on MC code
*It is confusing for users to not have the "Cancel" button in the dialog. Users must first come up with the idea of clicking Back and only then being able to click Cancel.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1742158 - Keep the cancel button as well as the back button when printing the calendar. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

This feels ugly but Alex is probably right about keeping the cancel button.

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

Your patch seems to impelment the "Back" button in the first dialog, but it should only be in the 2nd / final dialog?

And yes, it looks really ugly :-(

Comment 6

[WaltS48 [:walts48]]

I'm seeing this in using 95.0b4 on Fedora 34 Workstation, Gnome 40 desktop.

Error console output.

15:30:00.515 Uncaught (in promise) TypeError: cancelButton is null
init chrome://global/content/print.js:254
handleEvent chrome://global/content/print.js:1681
print.js:254:1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4b787679e37c
Keep the cancel button as well as the back button when printing the calendar. r=mkmelin,aleca

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9251817 [details]
Bug 1742158 - Keep the cancel button as well as the back button when printing the calendar. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1724090
User impact if declined: can't print calendar at all
Testing completed (on c-c, etc.): landed today but somewhat urgent
Risk to taking this patch (and alternatives if risky): low, but then again I probably said that about the patch that caused this

Comment 9

[Alex Ihrig [:Thunderbird_Mail_DE]]

Verified in Daily

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9251817 [details]
Bug 1742158 - Keep the cancel button as well as the back button when printing the calendar. r=mkmelin

[Triage Comment]
Approved for beta

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9251817 [details]
Bug 1742158 - Keep the cancel button as well as the back button when printing the calendar. r=mkmelin

[Triage Comment]
Approved for ers91

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 95.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/28ac327071c4

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.4.0:
https://hg.mozilla.org/releases/comm-esr91/rev/f1c33cf39ee9

Comment 16

[WaltS48 [:walts48]]

Verified in testing 91.4.0 and 95.0b5 on Windows 10 and Fedora 35 Workstation Linux.