1742234 - Search for "Attachment" in Settings menu does not find "Files and Attachments"

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Stuart]

Attachment: bugzilla-TB-1.png

Steps to reproduce:

Open Settings (Tools > Settings) and type in the search box "attachemnt" or "attachments".

Tried this initially in TB 78. Tried to reproduce in TB 91 but couldn't open settings/preferences/options due to bug 1725955 so reproduced in TB 95.

Actual results:

Got results for settings mentioning attachments specifically.

Expected results:

Should have also seen results for titles including attachments. Was looking for the file type/attachment handling settings which weren't listed in the results. Assume this search is searching the settings only and ignoring the section headers/titles?

Comment 1

[Wayne Mery (:wsmwk)]

Tcw can you reproduce?

Comment 2

[Arthur K. (he/him)]

Attachment: search-menu.png

Looks normal to me. What do you think? OP, what other setting is missing here?

Comment 3

[Arthur K. (he/him)]

Ah, ok, you were also expecting it to show Files & Attachments. Yeah, I guess that should qualify as a search hit.

Comment 4

[Stuart]

(In reply to Arthur K. [He/Him] from comment #3)

Ah, ok, you were also expecting it to show Files & Attachments. Yeah, I guess that should qualify as a search hit.

That's correct yes.

Comment 5

[Alessandro Castellani [:aleca]]

This is a known issue due to how the search code performs against attributes as it tries to match the label attribute of an element.
Since that title is an html:h1 element, it doesn't have a label therefore it doesn't come up in the search results.

This issue happens with pretty much any HTML element (like Tags, Language & Appearance, etc.), and it's not a TB only issue as it happens also in Firefox.

Comment 6

[David Booth]

(In reply to Alessandro Castellani [:aleca] from comment #5)

Alessandro, if this is a known issue, where is it being tracked and what is the status of getting it fixed? Regardless of the cause, it's kind of crazy that "Files and Attachments" does not show up when searching for "Attachments".

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1742234 - Have 'Find in Settings" retrieve matching subcategories. r=freaktechnik

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/375f48c3f909
Have 'Find in Settings" retrieve matching subcategories. r=freaktechnik