1742471 - Permissions should not prompt for addon gated permissions

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, task, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Some permissions for dom apis will be gated by a requirement to install an addon, which is how the permission will be granted. The site permissions prompting should check if the permission is addon gated, and simply return whatever value is already in permissions.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1742471 enforce addon gating of webmidi interfaces

Comment 2

[Shane Caraveo (:mixedpuppy)]

[Tracking Requested - why for this release]: With the site permissions addon type included in 97, we should ensure either a) we do not enable midi in 97, or b) we ensure that the normal prompt process does not happen (ie. we land this patch)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aed9e1265d5d
enforce addon gating of webmidi interfaces r=gsvelto

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/aed9e1265d5d

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitest failures on test_midi_permission_gated.html. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/915f7d3498989668d2f6da802d7db5da63dfe153

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Ccross-origin%2Cand%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-plain-fis-xorig-e10s%2C11&revision=aed9e1265d5ddadb4747a0a648de7f7ba0a31166&selectedTaskRun=RC82TqwrSDaQmhjg1GIIZg.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=362215994&repo=autoland&lineNumber=5262

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5eef44c00ca6
enforce addon gating of webmidi interfaces r=gsvelto

Comment 7

[Atila Butkovits]

Backed out for causing failures at test_midi_permission_gated.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ceb33211e561efc5fc8148fea3629d04c192b4b5

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Lc8wl4a9SYWOi305ZhTioQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=17ba362cea77a629f69dc473b134f0c1fa6ff46c

Failure log: https://treeherder.mozilla.org/logviewer?job_id=362243958&repo=autoland&lineNumber=5296
https://treeherder.mozilla.org/logviewer?job_id=362243707&repo=autoland&lineNumber=3931

Comment 8

[Shane Caraveo (:mixedpuppy)]

gsvelto will look into the crash

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc6aa54c6713
enforce addon gating of webmidi interfaces r=gsvelto

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bc6aa54c6713