1742865 - Back button does not work any more with auto-refresh pages

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Laurent Frigault]

Attachment: ffbackbug.tgz with a.html and b.html to reproduce the issue

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

1/ Open a web pages (a.html) with a link to an other page (b.html) with auto-refresh.
2/ click on the link to b.html.
3/ without waiting the refresh period of the second page click on the back button
=> you return to the first page a.html .
4/click again on the link to the second page b.html with an auto-refresh
5/ wait for a few auto-refresh period
6/ click on the back button
=> you did not return to the first page a.html but stay on the second page b.html with the auto-refresh

Actual results:

Its looks like every auto-refresh of the page is handled like a link to it and pushed to the back button history. You need to click on the back button one time for every refresh.

Expected results:

auto-refresh pages should not push an entry in the back button history .

It works with safari and chrome and used to works with firefox. This seems to be a recent bug.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Navigation' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Peter Van der Beken [:peterv]]

Hmm, for some reason nsIWebNavigation::LOAD_FLAGS_REPLACE_HISTORY isn't set in the load type.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Bug 1742865 - Handle meta refresh correctly with session history in the parent. r?smaug!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9fc94b33da9
Handle meta refresh correctly with session history in the parent. r=smaug

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing wpt failures on attr-meta-http-equiv-refresh/parsing.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/49e1c067ecf7477a49c3efeb9b6196c44417a476

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7b01edc5a0e037508da8ccd2f37df4e5091f3b3a&selectedTaskRun=HMef7vizSfKqEb7xwKLtHg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=361164527&repo=autoland&lineNumber=7208

Failure line: TEST-UNEXPECTED-PASS | /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html?101-110 | Refresh header: "-0; foo" - expected FAIL // TEST-UNEXPECTED-PASS | /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html?101-110 | <meta>: "-1" - expected FAIL

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e55eb174b342
Handle meta refresh correctly with session history in the parent. r=smaug

Comment 9

[Atila Butkovits]

Backed out for causin failures at attr-meta-http-equiv-refresh/parsing.html?131

Backout link: https://hg.mozilla.org/integration/autoland/rev/fbb5c0ffa3642711abe037729412a38022ca776a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=android%2C7.0%2Cx86-64%2Clite%2Cwebrender%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64-lite-qr%2Fopt-geckoview-web-platform-tests-e10s%2Cwpt2&revision=e55eb174b342c4ded8f84304980a866ba810eabd

Failure log: https://treeherder.mozilla.org/logviewer?job_id=361466986&repo=autoland&lineNumber=2318

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9896c12c4907
Handle meta refresh correctly with session history in the parent. r=smaug

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9896c12c4907

Comment 12

[Chris Peterson [:cpeterson]]

Peter, should your fix be uplifted to Beta 96? Do you know of any real world websites that are affected by this bug? There still three weeks remaining in the Beta 96 cycle.

Comment 13

[Jarosław Rafa]

Many web applications that I work wigh at my daily job use auto refresh and this how I found this issue and reported the bug 1743620 which is a duplicate of this bug. It's really very, very inconvenient when you constantly work with auto refreshing pages.

Comment 14

[Ernst Mikkelsen]

I'm not sure how I should interpret "real world websites", as the sites where this is most annoying are not published. But our network monitoring system (Xymon) and our network management system (UniFi controller) suffers from this problem. It is indeed very inconvenient.

Comment 15

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Chris Peterson [:cpeterson] from comment #12)

Peter, should your fix be uplifted to Beta 96? Do you know of any real world websites that are affected by this bug? There still three weeks remaining in the Beta 96 cycle.

Peter is away for 3 weeks. Per comment 13 and comment 14, this looks something worth getting uplifted. Olli, would you be able to take care of uplifting in lieu of Peter? thank you.

Comment 16

[Peter Van der Beken [:peterv]]

Comment on attachment 9253686 [details]
Bug 1742865 - Handle meta refresh correctly with session history in the parent. r?smaug!

Beta/Release Uplift Approval Request

• User impact if declined: Auto-refreshing pages fill up the history menu.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix applies a check for meta-refresh pages, and then reuses existing code for that specific case.
• String changes made/needed: None

Comment 17

[Dianna Smith [:diannaS]]

Comment on attachment 9253686 [details]
Bug 1742865 - Handle meta refresh correctly with session history in the parent. r?smaug!

Approved for 96.0b8

Comment 18

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/59015abb2b56

Comment 21

[Timea Zsoldos [:tzsoldos], Desktop QA]

This issue was fixed on the Latest Nightly build 132.0a1, verified on multiple platforms: Windows 10, macOS 12 and Ubuntu 22.04 followed the steps from description, back button works on auto refresh pages from attachment.

Comment 22

[Adina Petridean QA [:apetridean]]

Verified as fixed on Android as well, on the latest Nightly 132.0a1 from 05.09.2024 using Samsung Galaxy S23 Ultra (Android 14).