1743339 - [GTK] Native key bindings of "Select All" is not respected in `<input>`

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We respect select-all signal, but it's not supported on GtkEntry widget. Perhaps, it should be respected if a key combination is not mapped to anything in GtkEntry, but it's mapped to select-all in GtkTextView.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1743339 - Make `NativeKeyBindings` for single line editor try the one for multiline editor too r=stransky!

GtkEntry is used to check what editing or natvigation command is
mapped to every key combination when <input> has focus. However,
it does not support select-all signal, thus, Gecko does not respect
native shortcut key for "Select All".

This patch makes it try to check whether the given key combination is
mapped to "Select All" or not in GtkTextView widget which supports
select-all signal. Thus, we'll get consistent behavior between
<input> and <textarea> about "Select All".

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

stransky: Could you review the patch? I'd like to land it in this cycle because bug 1376091 was landed in this cycle and some Linux users want to keep the traditional behavior (i.e., Alt-a being "Select All") with customizing GTK's shortcut key definition. Even though it's too late to change this behavior, but I'd like to land the new pref which is disabled by default.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Sorry for the delay.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a6a6fdfc7ff
Make `NativeKeyBindings` for single line editor try the one for multiline editor too r=stransky

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/5a6a6fdfc7ff