Closed Bug 1743987 Opened 2 years ago Closed 2 years ago

Remove (disabled) suffix from themes and stop fading disabled themes

Categories

(Toolkit :: Add-ons Manager, enhancement, P1)

enhancement
Points:
2

Tracking

()

RESOLVED FIXED
97 Branch
Iteration:
96.3 - Nov 29 - Dec 6
Tracking Status
firefox97 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

In bug 1729535, we added a colorways section to the Themes section of about:addons. These aren't faded despite being technically disabled. We should expand that behavior to cover all themes in order to make it easier for users to do what this UI is meant to facilitate: select a theme. Likewise, let's get rid of the "(disabled)" suffix, which is redundant with the sub headings and otherwise not useful as there's only ever one enabled theme at the top of the page.

Iteration: --- → 96.3 - Nov 29 - Dec 6
Points: --- → 2
Attachment #9253384 - Attachment description: Bug 1743987 - Remove (disabled) suffix from themes and stop fading disabled themes. r=mixedpuppy,harry → Bug 1743987 - Remove (disabled) suffix from themes and stop fading disabled themes. r=mixedpuppy
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/846f0c8241e6
Remove (disabled) suffix from themes and stop fading disabled themes. r=mixedpuppy
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af0471da595f
Backed out changeset 846f0c8241e6 for causing bc failures in browser_html_list_view.js

Backed out changeset 846f0c8241e6 for causing bc failures in browser_html_list_view.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/af0471da595f
Push with failures, failure log.

Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/496c73499d28
Remove (disabled) suffix from themes and stop fading disabled themes. r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: