1745244 - Message bar buttons don't use the correct colours with HCT

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

In Windows' high contrast mode the buttons on the message bars (content blocking etc.) use still the default theme colours and not the high contrast colours.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1745244-message-bar-HCT.patch

We have to add @media (prefers-contrast) {} colour values.

The IMIP bar needs also a fix to use the correct background colour.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9254588 [details] [diff] [review]
1745244-message-bar-HCT.patch

Review of attachment 9254588 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Please update the commit message with "[Windows] Fix high contrast colors for IMIP bar buttons"

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1745244-message-bar-HCT.patch

Updated the commit message.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3d340c1f9f3e
Fix high contrast colors for IMIP bar buttons. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9254883 [details] [diff] [review]
1745244-message-bar-HCT.patch

[Approval Request Comment]
User impact if declined: in HCT mode unreadable "unread" messages in thread tree
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1745244-message-bar-HCT-ESR.patch

[Approval Request Comment]
User impact if declined: in HCT mode unreadable "unread" messages in thread tree
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9254883 [details] [diff] [review]
1745244-message-bar-HCT.patch

[Triage Comment]
Approved for 96.0b2

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 96.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/7daa91abc262

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9255027 [details] [diff] [review]
1745244-message-bar-HCT-ESR.patch

[Triage Comment]
Approved for esr91

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/15137e450ae8