1745759 - [DNR] Prototype of urlFilter condition

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P1)

Description

[Rob Wu [:robwu]]

Implement the matcher for URLs using the DNR urlFilter syntax as described at https://developer.chrome.com/docs/extensions/reference/declarativeNetRequest/##property-RuleCondition-urlFilter

Comment 1

[Rob Wu [:robwu]]

Attachment: snippet-urlFilter-testCases-from-Chromium.js

In the patch to this bug, I included unit tests that I imported from Chrome, to verify that we have parity on the implementation of urlFilter.

Chrome's tests at https://chromium.googlesource.com/chromium/src.git/+/refs/tags/110.0.5442.0/components/url_pattern_index/url_pattern_unittest.cc do not directly test the urlFilter string, but a parsed internal representation. There are two notable tests, an empty pattern + kSubdomain+kAnchorNone and kBoundary+kBoundary. Both of these are serialized as "||". In practice, "||" is interpreted as a subdomain anchor, not as Left anchor + Right anchor.

The implementation that I am attaching to this bug passes all tests (imported ones + new ones).

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1745759 - Implement DNR urlFilter condition

Comment 3

[Rob Wu [:robwu]]

Attachment: snippet-urlFilter-testCases-from-Chromium.js

Update to https://bugzilla.mozilla.org/show_bug.cgi?id=1745759#c1 : include the original URLPattern constructor details in a comment to make it easier to compare the converted/imported test with the original source.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/055fc5e09a3e
Implement DNR urlFilter condition r=rpl

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/055fc5e09a3e