1782685 - [DNR] Ship DNR API on release

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task, P2)

Description

[Rob Wu [:robwu]]

This bug is about flipping the extensions.dnr.enabled pref to true (or even removing the pref).

Comment 1

[Rob Wu [:robwu]]

FYI: documentation is being written and reviewed at https://github.com/mdn/content/pull/22644 and https://github.com/mdn/browser-compat-data/pull/18403 .

Comment 2

[Rob Wu [:robwu]]

With the implementation having been mostly completed, we want to do some optimization work and then ship the API. That means:

• Make the API available to MV2 and MV3.
• Do not require a preference to use the API.

Before shipping, we should consider whether to ship with the current implementation of regexFilter as is, or whether to strictly validate and restrict the syntax (bug 1821033). The advantage of the current implementation is that the regexFilter syntax is now identical to JS, the disadvantage is that the syntax may be broader than required in practice. If we were to restrict the syntax in the future, that could potentially break extensions. For more details on regexFilter, follow bug 1821033.

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 1782685 - Remove MV3 requirement from DNR

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1782685 - Turn on availability of DNR API

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03d9da4ac52f
Remove MV3 requirement from DNR r=rpl
https://hg.mozilla.org/integration/autoland/rev/ecda751ce0ea
Turn on availability of DNR API r=rpl

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/03d9da4ac52f
https://hg.mozilla.org/mozilla-central/rev/ecda751ce0ea

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Is this something we want to call out in the Fx113 relnotes? Please nominate if so.

Comment 8

[Rob Wu [:robwu]]

We usually do not call out extension API in the user release notes. We will add it to the Firefox release notes for developers article on MDN.

Comment 9

[rbloor]

The following documentation updates have been made:

• MDN content
• #26142 (Release note, merged),
• #26168 (optional and no prompt permissions update)
• BCD #19362

Comment 10

[Rob Wu [:robwu]]

I have posted reviews/feedback on the issues, and expect them to be resolved eventually. Marking as dev-doc-complete.

PS. The majority of the DNR documentation was authored in https://github.com/mdn/content/pull/22644 and https://github.com/mdn/browser-compat-data/pull/18403