1746189 - An extra blank space is displayed at the bottom of the about:logins page after a new login is saved

Status: VERIFIED FIXED

(Firefox :: about:logins, defect)

Description

[Anca Soncutean, Desktop QA]

Attachment: screenshot issue.png

Affected versions

• 97.0a1 (2021-12-15)
• 96.0b5

Affected platforms

• Windows 10
• Ubuntu 16.04
• macOS 10.14

Steps to reproduce

1. Open the about:logins page
2. Click on the Create New Login button
3. Provide relevant information inside the required fields
4. Click on the Save button
5. Scroll down the page a little bit

Expected result

• No unnecessary space is displayed on the page.

Actual result

• An extra blank space is displayed at the bottom of the page.

Regression range

• Last good revision: 5fe3c617d521ed21ffd41b8060dc1351e90650d1
• First bad revision: ef598c9dc54b222d8420286fbba72533c57d8505
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5fe3c617d521ed21ffd41b8060dc1351e90650d1&tochange=ef598c9dc54b222d8420286fbba72533c57d8505
• Regressor bug: 1739390

Other notes

• No functionality seams to be affected.

Comment 1

[Sergey Galich [:serg]]

related fix https://phabricator.services.mozilla.com/D133227

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1739390

Comment 3

[Ryan VanderMeulen [:RyanVM]]

It's kind of messy for tracking purposes landing patches in a meta bug. Please don't in the future. Also, please set dependencies when a patch from another bug fixes this one. Finally, this bug also affects Fx96 - can you please nominate the patch from bug 1745020 for Beta approval so we can fix this bug there as well? Thanks!

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 97.0a1 (Build ID: 20211219214917) on Windows 10 x64, macOS 11.6 and Ubuntu 20.04.

• There is no more extra space at the bottom of the page after creating a new login.

Comment 5

[Tim Giles [:tgiles]]

Attachment: Bug 1746189 - An extra blank space is displayed at the bottom of the about:logins page after a new login is saved r=sgalich

Comment 6

[Sergey Galich [:serg]]

Comment on attachment 9256210 [details]
Bug 1746189 - An extra blank space is displayed at the bottom of the about:logins page after a new login is saved r=sgalich

Beta/Release Uplift Approval Request

• User impact if declined: broken scrolling in about:logins
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's low risk because we adjust layout to fit to the page without adding extra scrolling.
• String changes made/needed:

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9256210 [details]
Bug 1746189 - An extra blank space is displayed at the bottom of the about:logins page after a new login is saved r=sgalich

Approved for 96.0b8

Comment 8

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/14998840931e

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using Firefox Beta 96.0b8 (Build ID: 20211221185759) on Windows 10 x64, macOS 11.6 and Ubuntu 20.04.

• There is no extra space at the bottom of the page after creating a new login.

However, while verifying this issue, I've noticed that the scrollbar is missing, and the page cannot be scrolled anymore to see all the elements from the page when it is resized. @Sergey can I file a new issue for this behavior?

Comment 10

[Sergey Galich [:serg]]

(In reply to Simona Rosu [:srosu], Ecosystem QA from comment #9)

I have verified this issue using Firefox Beta 96.0b8 (Build ID: 20211221185759) on Windows 10 x64, macOS 11.6 and Ubuntu 20.04.

• There is no extra space at the bottom of the page after creating a new login.

However, while verifying this issue, I've noticed that the scrollbar is missing, and the page cannot be scrolled anymore to see all the elements from the page when it is resized. @Sergey can I file a new issue for this behavior?

@Simona I see the same, can't scroll login details if the page is too small. Please file a new bug for that.