1747919 - Clean up some more deprecated GTK symbols

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task)

Description

[Robert Mader [:rmader]]

Right now I get:

 1:55.42 warning: widget/gtk/MozContainer.cpp:151:3 [-Wdeprecated-declarations] 'gtk_container_set_resize_mode' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:118:23 [-Wdeprecated-declarations] 'gtk_handle_box_new' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:148:23 [-Wdeprecated-declarations] 'gtk_arrow_new' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:228:32 [-Wdeprecated-declarations] 'gtk_arrow_get_type' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:230:14 [-Wdeprecated-declarations] 'gtk_arrow_get_type' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:339:32 [-Wdeprecated-declarations] 'gtk_arrow_get_type' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:341:14 [-Wdeprecated-declarations] 'gtk_arrow_get_type' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:512:3 [-Wdeprecated-declarations] 'gtk_style_context_invalidate' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:513:3 [-Wdeprecated-declarations] 'gtk_style_context_invalidate' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:642:3 [-Wdeprecated-declarations] 'gtk_style_context_invalidate' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:834:5 [-Wdeprecated-declarations] 'gtk_style_context_invalidate' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:1197:7 [-Wdeprecated-declarations] 'gtk_style_context_add_region' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:1204:7 [-Wdeprecated-declarations] 'gtk_style_context_add_region' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:1361:7 [-Wdeprecated-declarations] 'gtk_style_context_add_region' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:1366:7 [-Wdeprecated-declarations] 'gtk_style_context_add_region' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:1441:37 [-Wdeprecated-declarations] 'gtk_style_context_get_direction' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:1443:7 [-Wdeprecated-declarations] 'gtk_style_context_set_direction' is deprecated
 1:55.43 warning: widget/gtk/WidgetStyleCache.cpp:1461:5 [-Wdeprecated-declarations] 'gtk_style_context_invalidate' is deprecated
 1:55.43 warning: widget/gtk/gtk3drawing.cpp:705:19 [-Wdeprecated-declarations] 'gtk_misc_get_type' is deprecated
 1:55.43 warning: widget/gtk/gtk3drawing.cpp:710:3 [-Wdeprecated-declarations] 'gtk_misc_get_padding' is deprecated
 1:55.43 warning: widget/gtk/gtk3drawing.cpp:714:3 [-Wdeprecated-declarations] 'gtk_misc_get_alignment' is deprecated
 1:55.43 warning: widget/gtk/nsDragService.cpp:390:7 [-Wdeprecated-declarations] 'gtk_drag_begin' is deprecated
 1:55.43 warning: widget/gtk/nsDragService.cpp:1428:7 [-Wdeprecated-declarations] 'gdk_display_get_pointer' is deprecated
 1:55.43 warning: widget/gtk/nsFilePicker.cpp:136:3 [-Wdeprecated-declarations] 'gtk_misc_set_padding' is deprecated
 1:55.43 warning: widget/gtk/nsFilePicker.cpp:136:24 [-Wdeprecated-declarations] 'gtk_misc_get_type' is deprecated
 1:55.43 warning: widget/gtk/nsFilePicker.cpp:602:63 [-Wdeprecated-declarations] 'GtkStock' is deprecated
 1:55.43 warning: widget/gtk/nsFilePicker.cpp:603:63 [-Wdeprecated-declarations] 'GtkStock' is deprecated
 1:55.43 warning: widget/gtk/nsFilePicker.cpp:606:30 [-Wdeprecated-declarations] 'GtkStock' is deprecated
 1:55.43 warning: widget/gtk/nsFilePicker.cpp:608:3 [-Wdeprecated-declarations] 'gtk_dialog_set_alternative_button_order' is deprecated
 1:55.43 warning: widget/gtk/nsGtkKeyUtils.cpp:968:3 [-Wdeprecated-declarations] 'gdk_display_get_pointer' is deprecated
 1:55.43 warning: widget/gtk/nsLookAndFeel.cpp:267:8 [-Wdeprecated-declarations] 'gtk_style_properties_lookup_property' is deprecated
 1:55.43 warning: widget/gtk/nsLookAndFeel.cpp:1760:3 [-Wdeprecated-declarations] 'gtk_style_context_add_region' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:71:43 [-Wdeprecated-declarations] 'GtkStock' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:72:7 [-Wdeprecated-declarations] 'GtkStock' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:75:3 [-Wdeprecated-declarations] 'gtk_dialog_set_alternative_button_order' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:83:7 [-Wdeprecated-declarations] 'gtk_image_new_from_stock' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:83:32 [-Wdeprecated-declarations] 'GtkStock' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:95:28 [-Wdeprecated-declarations] 'gtk_vbox_new' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:99:28 [-Wdeprecated-declarations] 'gtk_hbox_new' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:187:35 [-Wdeprecated-declarations] 'gtk_vbox_new' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:193:40 [-Wdeprecated-declarations] 'gtk_vbox_new' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:218:45 [-Wdeprecated-declarations] 'gtk_vbox_new' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:234:3 [-Wdeprecated-declarations] 'gtk_misc_set_alignment' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:234:26 [-Wdeprecated-declarations] 'gtk_misc_get_type' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:236:37 [-Wdeprecated-declarations] 'gtk_alignment_new' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:237:3 [-Wdeprecated-declarations] 'gtk_alignment_set_padding' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:237:29 [-Wdeprecated-declarations] 'gtk_alignment_get_type' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:241:45 [-Wdeprecated-declarations] 'gtk_vbox_new' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:253:3 [-Wdeprecated-declarations] 'gtk_misc_set_alignment' is deprecated
 1:55.43 warning: widget/gtk/nsPrintDialogGTK.cpp:253:26 [-Wdeprecated-declarations] 'gtk_misc_get_type' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:255:40 [-Wdeprecated-declarations] 'gtk_alignment_new' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:256:3 [-Wdeprecated-declarations] 'gtk_alignment_set_padding' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:256:29 [-Wdeprecated-declarations] 'gtk_alignment_get_type' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:260:36 [-Wdeprecated-declarations] 'gtk_table_new' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:272:5 [-Wdeprecated-declarations] 'gtk_table_attach' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:272:22 [-Wdeprecated-declarations] 'gtk_table_get_type' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:279:5 [-Wdeprecated-declarations] 'gtk_table_attach' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:279:22 [-Wdeprecated-declarations] 'gtk_table_get_type' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:292:5 [-Wdeprecated-declarations] 'gtk_table_attach' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:292:22 [-Wdeprecated-declarations] 'gtk_table_get_type' is deprecated
 1:55.44 warning: widget/gtk/nsPrintDialogGTK.cpp:301:48 [-Wdeprecated-declarations] 'gtk_vbox_new' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:3334:11 [-Wdeprecated-declarations] 'gtk_icon_theme_add_builtin_icon' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:3987:24 [-Wdeprecated-declarations] 'gdk_display_get_window_at_pointer' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:5318:9 [-Wdeprecated-declarations] 'gtk_window_set_opacity' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:5839:7 [-Wdeprecated-declarations] 'gtk_widget_set_double_buffered' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:6790:12 [-Wdeprecated-declarations] 'gdk_pointer_grab' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:6825:3 [-Wdeprecated-declarations] 'gdk_pointer_ungrab' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:6906:3 [-Wdeprecated-declarations] 'gtk_widget_modify_bg' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:6908:3 [-Wdeprecated-declarations] 'gtk_window_set_opacity' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:6950:3 [-Wdeprecated-declarations] 'gtk_window_set_opacity' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:7629:24 [-Wdeprecated-declarations] 'gdk_display_get_window_at_pointer' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:8512:5 [-Wdeprecated-declarations] 'gtk_widget_reparent' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:8538:5 [-Wdeprecated-declarations] 'gtk_widget_reparent' is deprecated
 1:55.44 warning: widget/gtk/nsWindow.cpp:8765:7 [-Wdeprecated-declarations] 'gdk_display_warp_pointer' is deprecated

Clean this up a bit.

Comment 1

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gdk_display_get_window_at_pointer(), r=stransky

GdkDeviceManager is also deprecated by now, but its successor,
GdkSeat, is not available in all supported versions.

Comment 2

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Stop gtk_widget_set_double_buffered(), r=stransky

Introduced in bug 153805, it appears to have been GTK2-only fix.
At least the comment lost during refactorings in
https://bug793501.bmoattachments.org/attachment.cgi?id=673088
implies that. Needs some testing.

Depends on D134793

Comment 3

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gdk_pointer_grab with gdk_device_grab, r=stransky

Depends on D134794

Comment 4

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gdk_pointer_grab with gdk_device_grab, r=stransky

Depends on D134794

Comment 5

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gtk_window_set_opacity with gtk_widget_set_opacity, r=stransky

Depends on D134797

Comment 6

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gtk_widget_reparent, r=stransky

Depends on D134798

Comment 7

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gtk_widget_modify_bg, r=stransky

Depends on D134812

Comment 8

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gdk_display_get_pointer, r=stransky

gdk_screen_get_root_window() appears to be used internally
by GTK, so this should match existing behaviour.

Depends on D134814

Comment 9

[Robert Mader [:rmader]]

https://treeherder.mozilla.org/jobs?repo=try&revision=c3817f895a0051e695dfe58bf910fbc3ff8902fc

Comment 10

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gtk_drag_begin, r=stransky

Depends on D134816

Comment 11

[Robert Mader [:rmader]]

https://treeherder.mozilla.org/jobs?repo=try&revision=2ec26e5d4bd9d9eaee6308ecd9b5e3d16a9d8e64

Comment 12

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Stop using gtk_container_set_resize_mode, r=stransky

Apparently not needed any more, especially with GTK_RESIZE_IMMEDIATE,
and may introduce bugs.

Depends on D134817

Comment 13

[Robert Mader [:rmader]]

Last for today: https://treeherder.mozilla.org/jobs?repo=try&revision=1b5939ed76ca46d0a5ee8d6c3f3a738ec24a832e

Comment 14

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Replace gdk_display_warp_pointer, r=stransky

Depends on D134812

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Let's wait to 98 cycle to avoid surprises in beta.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Can some / all of these land?

Comment 17

[Robert Mader [:rmader]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #16)

Can some / all of these land?

Yes, just need to address the one issue that Martin raised. Will try to get to it in the next couple of days.

Comment 18

[Robert Mader [:rmader]]

Attachment: Bug 1747919 - Add helper function to get the GDK client pointer, r=stransky

We'll need the pointer device in various places to migrate away from
deprecated API.

Note: GdkDeviceManager is also already deprecated in new GTK3 versions
and we'll want to replace it by GdkSeat once our minimal requirements
allow it. Once that's the case, we'll see deprecation warnings for
GdkDeviceManager.

Comment 19

[Robert Mader [:rmader]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3cccfc19633582f349676ce12b4281bf3eb6c5c9

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dad6b8f85cec
Add helper function to get the GDK client pointer, r=stransky
https://hg.mozilla.org/integration/autoland/rev/1cc8476b9cf8
Replace gdk_display_get_window_at_pointer(), r=stransky
https://hg.mozilla.org/integration/autoland/rev/120a985f1f2d
Replace gdk_pointer_grab with gdk_device_grab, r=stransky
https://hg.mozilla.org/integration/autoland/rev/3c7ab35234b5
Replace gtk_window_set_opacity with gtk_widget_set_opacity, r=stransky
https://hg.mozilla.org/integration/autoland/rev/1508310c3f8c
Replace gtk_widget_reparent, r=stransky
https://hg.mozilla.org/integration/autoland/rev/8ec44392a6f5
Replace gdk_display_warp_pointer, r=stransky

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/069a1d2d1dd7
Replace gtk_widget_modify_bg, r=stransky
https://hg.mozilla.org/integration/autoland/rev/3984936585f8
Replace gdk_display_get_pointer, r=stransky
https://hg.mozilla.org/integration/autoland/rev/1268af4cee01
Replace gtk_drag_begin, r=stransky
https://hg.mozilla.org/integration/autoland/rev/e081702686a6
Stop using gtk_container_set_resize_mode, r=stransky

Comment 22

[Robert Mader [:rmader]]

Note that a bunch of deprecation warnings from comment 0 are not addressed here. The remaining ones are more clustered though and thus good to address in follow ups.

Comment 23

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dad6b8f85cec
https://hg.mozilla.org/mozilla-central/rev/1cc8476b9cf8
https://hg.mozilla.org/mozilla-central/rev/120a985f1f2d
https://hg.mozilla.org/mozilla-central/rev/3c7ab35234b5
https://hg.mozilla.org/mozilla-central/rev/1508310c3f8c
https://hg.mozilla.org/mozilla-central/rev/8ec44392a6f5
https://hg.mozilla.org/mozilla-central/rev/069a1d2d1dd7
https://hg.mozilla.org/mozilla-central/rev/3984936585f8
https://hg.mozilla.org/mozilla-central/rev/1268af4cee01
https://hg.mozilla.org/mozilla-central/rev/e081702686a6