Closed Bug 1748128 Opened 4 years ago Closed 4 years ago

In the standalone search bar, guess candidates are not displayed in the candidate window of ATOK (Japanese IME).

Categories

(Firefox :: Search, defect)

Desktop
Windows 10
defect

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox-esr91 --- wontfix
firefox95 --- wontfix
firefox96 --- wontfix
firefox97 --- wontfix
firefox98 --- fixed

People

(Reporter: alice0775, Assigned: daisuke)

References

(Regression)

Details

(Keywords: inputmethod, nightly-community, regression)

Attachments

(3 files)

Steps to reproduce:

  1. Prerequisite: install ATOK2021 and Enable standalone Search bar
  2. Start Firefox
  3. Select the Search bar
  4. IME on and Type moji

Actual results:
Guess candidates(推測候補ウィンドウ) are not displayed unless changing ATOK property(入力補助 > 特殊 > uncheck 「入力欄の属性を参照する」).

Expected results:
Guess candidates(推測候補ウィンドウ) should be displayed in the candidate window without changing ATOK property .
See attached screenshot.

Attachment #9257268 - Attachment description: guess candidates are displayed in the candidate window → guess candidates are displayed in the candidate window as expected, if disable `入力欄の属性を参照する` ATOK property
Attachment #9257268 - Attachment description: guess candidates are displayed in the candidate window as expected, if disable `入力欄の属性を参照する` ATOK property → `Guess candidates` are displayed in the candidate window as expected, if disable `入力欄の属性を参照する` ATOK property
Component: Search → Widget: Win32
Product: Firefox → Core
Summary: In the search bar, guess candidates are not displayed in the candidate window of ATOK (Japanese IME). → In the standalone search bar, guess candidates are not displayed in the candidate window of ATOK (Japanese IME).

Set release status flags based on info from the regressing bug 1239319

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jmathies)
Component: Widget: Win32 → Address Bar
Flags: needinfo?(jmathies) → needinfo?(gijskruitbosch+bugs)
Product: Core → Firefox

We just expose the input type (inputtype=search) on the relevant HTML element, and it's up to widget code to translate that for the relevant IME stuff and interact with the relevant TSF/IME APIs. The change got made for compatibility with Windows' built-in keyboards. I don't know why it breaks with this IME with this option set, not least because I do not speak the language used to define the options so do not understand their relevance... Maybe Daisuke can help, based on bug 1689055?

Component: Address Bar → Search
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(daisuke)

Thank you very much for the reporting, :alice0775!
(And also thank you very much for letting me know, :Gijs)

Yes, I as well could reproduce this issue on win11 pro as well.
I'll take a look at this.
Thanks!

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Attachment #9259878 - Attachment description: Bug 1748128: Avoid sending 'search' input score when ATOK is active. → Bug 1748128: Avoid sending 'search' input scope when ATOK is active.
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02ca8709ede0 Avoid sending 'search' input scope when ATOK is active. r=masayuki
Flags: needinfo?(daisuke)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

To apply this fix, need to turn intl.tsf.hack.atok.search_input_scope_disabled on.
However, please note that this change affects touch keyboard on touch screen.

QA Whiteboard: [qa-98b-p2]

Masayuki tells me that a new version (v32) of ATOK was released at the end of January 2022 which changes this behavior.

Daisuke-san, are you able to re-check the behavior now with and without the pref in Firefox and in Chrome (using a regular HTML input of type=search)?
(It seems like the only way to get an old version of ATOK is to buy the 一太郎 bundle which includes a specific version but Amazon is out of stock of last year's bundle.)

Masayuki was unsure about turning this pref on by default because it seems like ATOK has deliberately made a choice not to show the window unless a pref is set so we should not forcefully override it. Apparently testing the current version with the default settings, the window doesn't show even in Notepad. Masayuki will ask his contact at ATOK about this.

Depending on the outcome, it might, for example, make sense to turn the pref'ed behavior on only for Chrome documents, or for specific versions of ATOK.

Flags: needinfo?(daisuke)
Attached video atok32.0.2.mp4

Thank you very much, Brian! (I’m sorry for delay)
I have checked the behavior again with env below:

  • ATOK for Windows 32.0.2
  • Windows 11 Pro 21H2

As the result, it seems that we have still the same problem.
Please see the attached video.
The candidate window is not shown unless turning the pref introduced in this bug on.

Flags: needinfo?(daisuke)

(In reply to Daisuke Akatsuka (:daisuke) from comment #12)

As the result, it seems that we have still the same problem.
Please see the attached video.
The candidate window is not shown unless turning the pref introduced in this bug on.

Thank you! What about Chrome?

Yep, I forgot to check it, sorry!
I checked with Chrome canary 101.0.4903.0, and it also is the same behavior as Firefox.
That means the window is not shown unless unchecking "入力欄の属性を参照する" in ATOK setting.

Yes, I can reproduce the issue in Chrome98.
testcase data:text/html,<input type="search">

Thanks Daisuke and Alice!
I think the matches Masayuki's observation and means we should not turn this pref on by default? What do you think?
Or do you think it makes sense to turn on this behavior for chrome content only, for example?

(In reply to Brian Birtles (:birtles) from comment #16)

I think the matches Masayuki's observation and means we should not turn this pref on by default? What do you think?

Yes, I do not think that the pref should be enabled by default. Once we ignore other products intention, it may break other features of them too. For example, I requested JustSystems to stop doing any special handling on Gecko because it was impossible to fix some issues on Gecko side due to their hack. So now, this issue is an opposite case of that.

Or do you think it makes sense to turn on this behavior for chrome content only, for example?

From point of view of our UI development, we can remove "search" input scope from our any UI. Therefore, it's okay to make ignore the fact only in chrome context. On the other hand, doing it makes a regression same as bug 1239319 only for ATOK users. Therefore, even if we do it, we should check whether touch keyboard is used or not. If it's used, we should send input scope as-is for keeping "right" behavior for the touch keyboard.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: