1749375 - Use dark variant theme variant for PBM windows

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1749375 - Use dark theme for PBM windows. r=#desktop-theme-reviewers!

When privacy segmentation is enabled via pref, switch PBM windows to dark theme,
while retaining light theme for normal windows.

This patch does not change behavior if the active theme is already dark, e.g.
the default theme in dark mode, or firefox-compact-dark. In this case both
normal windows and PBM windows use dark theme.

A dark theme variant is only applied to PBM if the active theme sets darkTheme data.
This means for themes like firefox-compact-light we will not use dark styling in PBM.

Depends on D135247

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1749375 - Tests for dark PBM window theme. r=#desktop-theme-reviewers!

Depends on D135624

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1749375 - Put PBM dark theme behind a pref. r=#desktop-theme-reviewers!

Depends on D136029

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1be6a634b76
Use dark theme for PBM windows. r=desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/7afd82e404ae
Tests for dark PBM window theme. r=desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/e532a72c6ae8
Put PBM dark theme behind a pref. r=desktop-theme-reviewers,dao

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e1be6a634b76
https://hg.mozilla.org/mozilla-central/rev/7afd82e404ae
https://hg.mozilla.org/mozilla-central/rev/e532a72c6ae8