1749397 - Pressing a character shortly after 'enter' after typing a url still inputs a character

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[charles]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

Open a new tab.
Type 'google.com' into the search bar.
Then hit 'enter' and 't' almost at the same time but 'enter' slightly before the 't'.

Actual results:

The result is that it loads google.com but the search bar ends up saying 'google.comt'

Expected results:

It should either ignore the 't' key input or forward it to google.com.

Comment 1

[Drew Willcoxon :adw]

Reproducable on a recent Nightly. The urlbar ends up with an invalid pageproxystate in the newly loaded tab. May be related to key buffering.

Comment 2

[Ada C.]

I managed to reproduce this issue on Firefox Beta 96, Nightly 98.0a1, Release 95 and 91.5.0esr using macOS 11.6 (Big Sur), Windows 10 and Ubuntu 20.4. This looks like an older regression, reproduced it all the way to Firefox 85. Using mozregression, looked for a regression ranged and took me to:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=61c35792ca7021377e42150db54b3935b0fd3c40&tochange=b1a74943bc51bd3e62ea52242ec5e403ea3760bb

I suspect Bug 1641287 to be the culprit.

Comment 3

[Ada C.]

Daisuke, could you please take a look?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:ada.cristea, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your report, charles.
And, thank you very much for letting me know, Ada.

Yes, I as well could reproduce this issue.
And also, I confirmed that the same issue happens on urlbar as well.
I will fix this.
Thanks!

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1749397: Ignore char key input while processing enter key on urlbar.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1749397: Ignore char key input while processing enter key on searchbar.

Depends on D136711

Comment 8

[Phabricator Automation]

Comment on attachment 9260347 [details]
Bug 1749397: Ignore char key input while processing enter key on searchbar.

Revision D136712 was moved to bug 1751819. Setting attachment 9260347 [details] to obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6617ddd0198a
Ignore char key input while processing enter key on urlbar. r=adw

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6617ddd0198a

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 97(20220202182137) on macOS Big Sur 11. This issue is fixed on Firefox 98.0b5(20220215194438) and Nightly 99.0a1(20220215210051) on macOS Big Sur 11, x86_64(Ubuntu 20.04) and Win10.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

This and bug 1751819 seem like a pretty annoying papercut issue for affected users. What are your thoughts about an ESR uplift on them? They both graft cleanly.

Comment 13

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Ryan.
I will request uplifting for ESR.

Comment 14

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9260346 [details]
Bug 1749397: Ignore char key input while processing enter key on urlbar.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: It’s an annoying bug for users that we should fix, and the patch is relatively safe.
• User impact if declined: If user inputs text in the URL bar, then press the character key as soon as pressing “enter", the character will be added after the text in the URL bar. That is, the result of the web page will not match the value in the URL bar.
• Fix Landed on Version: 98
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It was already verified by QA, and it's been two weeks since this patch was available on Nightly, no bugs have been reported.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9260346 [details]
Bug 1749397: Ignore char key input while processing enter key on urlbar.

Approved for 91.7esr.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/e39559d91f7b

Comment 17

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello! I verified this on 91.7.0esr(20220228225400) on macos Big Sur 11, Linux x86_64(Ubuntu 20.04) and Win10 64-bit. Works as expected.