1751819 - Pressing a character shortly after 'enter' after typing a url still inputs a character on searchbar

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Daisuke Akatsuka (:daisuke)]

This is a similar bug for bug 1749397.
The following issue happens on not only url bar that will fix in bug 1749397 but search bar as well. In this bug, we fix the issue on especially search bar.

---

Steps to reproduce:

Open a new tab.
Type 'google.com' into the search bar.
Then hit 'enter' and 't' almost at the same time but 'enter' slightly before the 't'.

Actual results:
The result is that it loads google.com but the search bar ends up saying 'google.comt'

Expected results:
It should either ignore the 't' key input or forward it to google.com.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1751819: Ignore char key input while processing enter key on searchbar.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1673299

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a39e7c78b103
Ignore char key input while processing enter key on searchbar. r=adw

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a39e7c78b103

Comment 5

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9260538 [details]
Bug 1751819: Ignore char key input while processing enter key on searchbar.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: It’s an annoying bug for users that we should fix, and the patch is relatively safe.
• User impact if declined: If user inputs text in the search bar, then press the character key as soon as pressing “enter", the character will be added after the text in the search bar. That is, the result of the web page will not match the value in the search bar.
• Fix Landed on Version: 98
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It was already verified by QA, and it's been two weeks since this patch was available on Nightly, no bugs have been reported.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9260538 [details]
Bug 1751819: Ignore char key input while processing enter key on searchbar.

Approved for 91.7esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/1418b1962c1d