1757376 - Unable to type in Address Bar after opening new tab and pressing cmd + enter

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[daniel.skogly]

Attachment: ff-bug-address-bar.mp4

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:98.0) Gecko/20100101 Firefox/98.0

Steps to reproduce:

1. Open a new tab
2. Select Adress Bar
3. Press CMD + Enter
4. Attempt typing anything
5. If you have the address bar focused in another tab, you can try switching to this tab and attempt typing there too

Actual results:

It's impossible to type anything until the address bar loses and regains focus

Expected results:

It should be possible to type

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

I was able to reproduce the bug on BETA 98.0b9 and the current 99.0a1 on Nightly.

Comment 3

[Ivan Savov]

I run into this issue daily on FF 98.0 (64-bit) on macOS 11.6.3 (20G415).

It doesn't happen all the time, and seems to always be in the "main" FF window.

To get out of the typing-does-nothing state, I usually clock on another open tab then come back to the new tab and then typing works.

Comment 4

[Ivan Savov]

Update: to get out of the typing-in-the-addressbar-does-nothing state, I need to switch to another window (FF loses focus) then when I come back to FF I can type in the address bar again.

Comment 5

[Drew Willcoxon :adw]

Daisuke, mozregression points to bug 1749397. This is pretty bad, so could you take a look please? We should fix this in 99 and 91.7esr since it was uplifted there. The search bar is also affected due to bug 1751819. Worst case, we should back out those patches IMO.

Comment 6

[Daisuke Akatsuka (:daisuke)]

I am sorry for the inconvenience caused.
Yes, I also could reproduce it.
I'll take a look at it right away.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1757376: Continue post processing of Enter key when any keyup event is detected on URL bar.

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1757376: Continue post processing of Enter key when any keyup event is detected on search bar.

Depends on D140908

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cb40805ce3e
Continue post processing of Enter key when any keyup event is detected on URL bar. r=adw
https://hg.mozilla.org/integration/autoland/rev/b60025238614
Continue post processing of Enter key when any keyup event is detected on search bar. r=adw

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1cb40805ce3e
https://hg.mozilla.org/mozilla-central/rev/b60025238614

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 12

[Daisuke Akatsuka (:daisuke)]

Yes, thanks! And also, I will request uplifting to ESR as well since we uplifted the previous patch as well.

Comment 13

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9267498 [details]
Bug 1757376: Continue post processing of Enter key when any keyup event is detected on URL bar.

Beta/Release Uplift Approval Request

• User impact if declined: As the report, if user presses Cmd+Enter on URL bar/searchbar on OSX, user can't input any chars on the bar.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The essential changes are a few lines. Only loosened the conditions under which processing of the Enter key continues.
• String changes made/needed: None

Comment 14

[Alin Ilea, Desktop QA]

Reproduced the issue in Beta 99.0b3 using macOS 10.15
Verified - Fixed in latest Nightly 100.0a1 (2022-03-16). I am able to type anything in the address bar after pressing CMD + Enter, without moving the focus from the address bar and back.

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9267498 [details]
Bug 1757376: Continue post processing of Enter key when any keyup event is detected on URL bar.

Approved for 99.0b5. Thanks.

Comment 16

[Donal Meehan [:dmeehan]]

Comment on attachment 9267777 [details]
Bug 1757376: Continue post processing of Enter key when any keyup event is detected on search bar.

Approved for 99.0b5. Thanks.

Comment 17

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eecb1dc6221e
https://hg.mozilla.org/releases/mozilla-beta/rev/330a7985900a

Comment 18

[Drew Willcoxon :adw]

Daisuke, could you request uplift to esr91 please?

Comment 19

[Daisuke Akatsuka (:daisuke)]

Yep, thanks!

Comment 20

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9267498 [details]
Bug 1757376: Continue post processing of Enter key when any keyup event is detected on URL bar.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: It’s an annoying bug for users that we should fix, and the patch is relatively safe.
• User impact if declined: If user presses Cmd+Enter on URL bar/searchbar on OSX, user can't input any chars on the bar unless losing focus once.
• Fix Landed on Version: 99
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It was already verified by QA, and the essential changes are a few lines.

Comment 21

[Alin Ilea, Desktop QA]

Verified - Fixed in Beta 99.0b5 using macOS 10.15.

Comment 22

[daniel.skogly]

Attachment: ff-address-bar-new-tab-bug.mp4

Hi!

Just tried this out in 99.0b5 on macOS 12.3 (21E230), and unfortunately it seems like under this rock, there be more bugs. Apologies if these should be filed on separate bug reports, but they seem related to the current issue.

Address bar loses focus when selected immediately after CMD + Enter from a "New Tab"

Steps to reproduce:

Open a new tab
Select Adress Bar
Type anything
Press CMD + Enter
Immediately focus the address bar by using mouse cursor or CMD + L
If using CMD + L, attempt delaying the release of CMD

Actual results:

The address bar gains focus, then immediately loses it. If CMD + L is used, the address bar only loses focus when CMD is released.

Expected results:

The address bar should be focused, with all text selected

Address bar loses text selection when selected immediately after CMD + Enter from not "New Tab"

Steps to reproduce:

Go to a page that is _not_ the "New Tab" page
Select Adress Bar
Type anything
Press CMD + Enter
Immediately focus the address bar by using mouse cursor or CMD + L

Actual results:

The address bar gains focus, but text selection is lost, with the caret being placed either at the beginning or end of text

Expected results:

The address bar should be focused, with all text selected

Comment 23

[Mathew Hodson]

Please create a new bug for that.

Comment 24

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9267777 [details]
Bug 1757376: Continue post processing of Enter key when any keyup event is detected on search bar.

The fix works on Beta and is a 98 regression, the patch has tests, let's take it into 98.0.2.

Comment 25

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-release/rev/da225b8a63ee
https://hg.mozilla.org/releases/mozilla-release/rev/d99219423697

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9267498 [details]
Bug 1757376: Continue post processing of Enter key when any keyup event is detected on URL bar.

Approved for 91.8esr.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/6bd1a0058433
https://hg.mozilla.org/releases/mozilla-esr91/rev/dd04dec4548c

Comment 28

[Alin Ilea, Desktop QA]

Verified - Fixed in 98.0.2 (build id: 20220322144853) and 98.1.0esr (build id: 20220322163448) using macOS 10.15.

Comment 29

[Drew Willcoxon :adw]

Marco C. suggested we bump this up to S2, which seems reasonable to me.