1749499 - Update Prettier peer dependencies

Status: RESOLVED WORKSFORME

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mathieu Leplatre [:leplatrem]]

ESLint v8 and Prettier v2 came out.

eslint-plugin-mozilla relies on previous majors in peer dependencies:

npm ERR! Conflicting peer dependency: prettier@1.19.1
npm ERR! node_modules/prettier
npm ERR!   peer prettier@"^1.19.1" from eslint-plugin-mozilla@2.11.1
npm ERR!   node_modules/eslint-plugin-mozilla
npm ERR!     dev eslint-plugin-mozilla@"2.11.1" from the root project

npm ERR! Conflicting peer dependency: eslint@7.32.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^7.23.0" from eslint-plugin-mozilla@2.11.1
npm ERR!   node_modules/eslint-plugin-mozilla
npm ERR!     dev eslint-plugin-mozilla@"2.11.1" from the root project

Comment 1

[Mark Banner (:standard8)]

ESLint v8 is covered by bug 1725952. The main blocker there is the lack of support in Atom for it.

Prettier has been on my list for a while, but changes some of the formatting across the tree so needs a big update, and I need to talk to a few people about the changes.

Comment 2

[Alexandre Poirot [:ochameau]]

Note that we went through this "issue" while trying to synchronize lint rules between the source-map library hosted on github and mozilla-central:
https://github.com/mozilla/source-map/pull/467#discussion_r1016847704

Using the same prettierrc was not enough due to lint changes between prettier 1.9 and 2.0.

Comment 3

[Mark Banner (:standard8)]

(In reply to Alexandre Poirot [:ochameau] from comment #2)

Using the same prettierrc was not enough due to lint changes between prettier 1.9 and 2.0.

I plan to follow prettier's default (as was the sentiment when prettier first landed), but as mentioned above, I'll be looking to get a few agreements about the changes that are made. My current plan is to hit this around the time of the next ESR.

Comment 4

[Mark Banner (:standard8)]

This should get addressed in bug 1826062.

Comment 5

[Mark Banner (:standard8)]

Prettier has now been removed from the peer dependencies.