1826062 - Upgrade Prettier to the latest version

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

Prettier hasn't been updated for a few years, and it is about time that we did so. There's various improvements and new command line arguments to Prettier that have happened since 1.9.x.

Mainly due to the changes from 1.9 -> 2.0, there are quite a few places where we'll need to reformat the tree. Hence I'm planning on landing this during the 115 nightly cycle in May, before the next ESR happens.

Comment 1

[Mark Banner (:standard8)]

Note to self: as part of this we should pass the --no-error-on-unmatched-pattern to prettier and remove the work around in run_prettier (tools/lint/eslint/__init__.py), that was added in bug 1825507.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1826062 - Upgrade Prettier to v2.0.5. r?Mossop!

Also keeps 'arrowParens' as 'avoid', rather than switching to the new Prettier default of 'always'.

Depends on D176465

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r?Mossop!

Depends on D177018

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1826062 - Upgrade Prettier to 2.8.8. r?Mossop!

Depends on D177025

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r?Mossop!

Depends on D177026

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1826062 - Manual fixes for Prettier 2.0.5 upgrade. r?Mossop!

Depends on D177025

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 1826062 - Manual fixes for Prettier 2.8.8 upgrade. r?Mossop!

Depends on D177027

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a2728941930
Upgrade Prettier to v2.0.5. r=mossop
https://hg.mozilla.org/integration/autoland/rev/2077266ed81a
Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
https://hg.mozilla.org/integration/autoland/rev/2e415eb6a64e
Manual fixes for Prettier 2.0.5 upgrade. r=mossop,devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/43d78b92dff6
Upgrade Prettier to 2.8.8. r=mossop
https://hg.mozilla.org/integration/autoland/rev/c9194fb67b65
Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
https://hg.mozilla.org/integration/autoland/rev/6d9ab7bb3a77
Manual fixes for Prettier 2.8.8 upgrade. r=mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,robwu

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8a2728941930
https://hg.mozilla.org/mozilla-central/rev/2077266ed81a
https://hg.mozilla.org/mozilla-central/rev/2e415eb6a64e
https://hg.mozilla.org/mozilla-central/rev/43d78b92dff6
https://hg.mozilla.org/mozilla-central/rev/c9194fb67b65
https://hg.mozilla.org/mozilla-central/rev/6d9ab7bb3a77