Closed Bug 1750541 Opened 7 months ago Closed 1 month ago

Implement basic support for "script.callFunction" command

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

task
Points:
5

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [webdriver:m4])

Attachments

(1 file)

The command is similar to script.evaluate (bug 1742979) but allows to pass-in arguments to be used when evaluating the script. This means that the implementation here is dependent on bug 1742979, and further adds a small layer on-top mainly for argument handling.

Priority: -- → P3

Re-use the existing implementation for script.evaluate and add support for running the function wrapped Javascript code as passed-in via the functionDeclaration argument within the given browsing context.

Further we don't cover the following:

  • No support for returning Javascript data
  • By-passing CSP by default
  • No support for sandboxes

As such this bug is blocked on bug 1742979.

Blocks: 1770418
Points: --- → 5
Depends on: 1739976
No longer depends on: 1693838
Priority: P3 → P1
Blocks: 1770487
Blocks: 1770488
Blocks: 1770489
Blocks: 1770492
Depends on: 1693838
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Hi Julian. Does this bug need to be tagged for M4?

Flags: needinfo?(jdescottes)

(In reply to Marco Mucci [:MarcoM] from comment #2)

Hi Julian. Does this bug need to be tagged for M4?

Yes, not sure why we missed it. If you look at all the bugs blocked by this one, they are all in M4.

Flags: needinfo?(jdescottes)
Whiteboard: [webdriver:m4]

Henrik, this doesn't say if the basic implementation should support the thisParameter. For info it comes with the same issues/challenges as handling arguments, so if arguments are out of the basic implementation, I would also not include handling the thisParameter. What do you think?

Flags: needinfo?(hskupin)

This is correct and I totally missed that. Lets get a new bug filed and blocked on arguments and the complex object deserialization (strong handle).

Flags: needinfo?(hskupin)
Blocks: 1777460
No longer blocks: 1777460
Blocks: 1777460
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/726b20a2e9ae
[bidi] Implement basic support for "script.callFunction" command r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.