1750541 - Implement basic support for "script.callFunction" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The command is similar to script.evaluate (bug 1742979) but allows to pass-in arguments to be used when evaluating the script. This means that the implementation here is dependent on bug 1742979, and further adds a small layer on-top mainly for argument handling.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Re-use the existing implementation for script.evaluate and add support for running the function wrapped Javascript code as passed-in via the functionDeclaration argument within the given browsing context.

Further we don't cover the following:

• No support for returning Javascript data
• By-passing CSP by default
• No support for sandboxes

As such this bug is blocked on bug 1742979.

Comment 2

[Marco Mucci [:MarcoM]]

Hi Julian. Does this bug need to be tagged for M4?

Comment 3

[Julian Descottes [:jdescottes]]

(In reply to Marco Mucci [:MarcoM] from comment #2)

Hi Julian. Does this bug need to be tagged for M4?

Yes, not sure why we missed it. If you look at all the bugs blocked by this one, they are all in M4.

Comment 4

[Julian Descottes [:jdescottes]]

Henrik, this doesn't say if the basic implementation should support the thisParameter. For info it comes with the same issues/challenges as handling arguments, so if arguments are out of the basic implementation, I would also not include handling the thisParameter. What do you think?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is correct and I totally missed that. Lets get a new bug filed and blocked on arguments and the complex object deserialization (strong handle).

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1750541 - [bidi] Implement basic support for "script.callFunction" command

Depends on D150246

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/726b20a2e9ae
[bidi] Implement basic support for "script.callFunction" command r=webdriver-reviewers,whimboo

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/726b20a2e9ae