1750576 - Expose WebGPU shader compilation info

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, enhancement)

Description

[Dzmitry Malyshau [:kvark]]

We need to expose the shader compilation info. Currently our WebIDL has it commented out:

interface GPUShaderModule {
    //TODO:
    //Promise<GPUCompilationInfo> compilationInfo();
};

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: compilation-info.patch

My unfinished patch for this

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1750576 - WebGPU shader module asynchronous CompilationInfo API. r=jimb,emilio

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1750576 - Avoid passing raw strings in a couple of wgpu bindings entry points. r=emilio,jimb

Inspired by emilio's suggestion in the shader module API patch. This tries to be the most straightforward way to go from the strings coming from IPC to the ones consumed by wgpu.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a2e3c4ca14f
WebGPU shader module asynchronous CompilationInfo API. r=aosmond,emilio

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on RefPtr

Backout link: https://hg.mozilla.org/integration/autoland/rev/28d4584450219a70fcd6d6dd5edda54459a68353
Log link: https://treeherder.mozilla.org/logviewer?job_id=383514842&repo=autoland&lineNumber=33399

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be7493c6f3cb
WebGPU shader module asynchronous CompilationInfo API. r=aosmond,emilio
https://hg.mozilla.org/integration/autoland/rev/21ede22c4113
Avoid passing raw strings in a couple of wgpu bindings entry points. r=emilio

Comment 7

[Cristian Tuns]

Backed out for causing lint failures and build bustages

• Backout link
• Push with failures
• Failure Log Bustages
• Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/webgpu/WebGPUTypes.h:48:3: error: bad implicit conversion constructor for 'StringHelper'.
• Failure Log lint

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50901e1befca
WebGPU shader module asynchronous CompilationInfo API. r=aosmond,emilio
https://hg.mozilla.org/integration/autoland/rev/807e95cd9956
Avoid passing raw strings in a couple of wgpu bindings entry points. r=emilio

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/50901e1befca
https://hg.mozilla.org/mozilla-central/rev/807e95cd9956