1752090 - comm-central perm fail after bug 1748524 - toolkit/components/extensions/test/xpcshell/test_ext_eventpage_warning.js | test_eventpages - [test_eventpages : 1732] Did not get expected console message: ({message:/Event pages are not currently supported./})

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=365472782&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CRQC085hTwyOcLwoC8BNgQ/runs/0/artifacts/public/logs/live_backing.log

---

Backing out https://hg.mozilla.org/mozilla-central/rev/bee5e1a1f2013c73bfc93fdc067f6407d0c5b180 makes it go away.

Comment 1

[Magnus Melin [:mkmelin]]

John, can you take this one

Comment 2

[John Bieling (:TbSync)]

This has to be added to the test because we have a different default:

Services.prefs.setBoolPref(
  "extensions.webextensions.background-delayed-startup",
  true
);

Comment 3

[John Bieling (:TbSync)]

Could we switch the default for Daily and see what happens? I do not really know what that pref is doing or how much it is delaying startup.

Comment 4

[Shane Caraveo (:mixedpuppy)]

That pref should be false in general for xpcshell tests, but true otherwise. Unfortunately libpref/init/all.js has it set to false. This pref will eventually die, it's problematic for work we're doing right now.

Comment 5

[John Bieling (:TbSync)]

@Shane: Do I read you correctly, that we should not switch Thunderbird to use background-delayed-startup set to true, as it will go away and then it will behave like having that pref set to false again?

So the way forward is to file a bug against mozilla-central and set the pref to true to make the test pass on comm-central and mozilla-central?

Comment 6

[Magnus Melin [:mkmelin]]

The way we usually do this (it's bug 1168178 again), just change the test to make the test set the pref it in reality needs. Then at follows along whatever work is getting done on it...

Comment 7

[John Bieling (:TbSync)]

Attachment: Bug 1752090 - Enforce required value for the background-delayed-startup preference. r=rpl

Comment 8

[Intermittent Failures Robot]

27 failures in 581 pushes (0.046 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 27

Platform and build breakdown:

• windows10-64-2004-qr: 5
  • debug: 2
  • opt: 3
• macosx1015-64-qr: 5
  • debug: 3
  • opt: 2
• linux1804-64-qr: 5
  • debug: 3
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows10-32-2004-qr: 4
  • debug: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1752090&startday=2022-01-26&endday=2022-01-26&tree=all

Comment 9

[Intermittent Failures Robot]

23 failures in 697 pushes (0.033 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 23

Platform and build breakdown:

• macosx1015-64-qr: 4
  • opt: 2
  • debug: 2
• linux1804-64-qr: 4
  • opt: 2
  • debug: 2
• windows10-64-2004-qr: 4
  • debug: 2
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2
• windows10-32-2004-qr: 4
  • debug: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1752090&startday=2022-01-27&endday=2022-01-27&tree=all

Comment 10

[Intermittent Failures Robot]

50 failures in 3445 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #14 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 50

Platform and build breakdown:

• windows10-64-2004-qr: 9
  • debug: 4
  • opt: 5
• macosx1015-64-qr: 9
  • debug: 5
  • opt: 4
• linux1804-64-qr: 9
  • debug: 5
  • opt: 4
• linux1804-64-shippable-qr: 4
  • opt: 4
• windows10-32-2004-qr: 8
  • debug: 4
  • opt: 4
• windows10-32-2004-shippable-qr: 3
  • opt: 3
• macosx1015-64-shippable-qr: 4
  • opt: 4
• windows10-64-2004-shippable-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1752090&startday=2022-01-24&endday=2022-01-30&tree=all

Comment 11

[Shane Caraveo (:mixedpuppy)]

(In reply to John Bieling (:TbSync) from comment #5)

@Shane: Do I read you correctly, that we should not switch Thunderbird to use background-delayed-startup set to true, as it will go away and then it will behave like having that pref set to false again?

No, exactly the opposite. TB should set it to true, otherwise when we remove the pref, TB will be forced to true, and you wont have found any issues you might have.

The pref should only be set to false in a test if you are entirely certain it is ok to. Ultimately all those tests will have to be fixed.

So the way forward is to file a bug against mozilla-central and set the pref to true to make the test pass on comm-central and mozilla-central?

m-c doesn't need that. And rather than editing a single test, you should set it to true in comm-central for TB like it is for firefox.

https://searchfox.org/mozilla-central/rev/78963fe42f8d5f582f84da84a5e78377b6c1fc32/browser/app/profile/firefox.js#67

Comment 12

[John Bieling (:TbSync)]

Thanks for the clarification, Shane.

Could you give a few details what that pref is actually doing? Until what point during startup will the execution of background scripts be delayed? Is there any documentation I could read to learn more about it and its consequences?

Comment 13

[Magnus Melin [:mkmelin]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #11)

So the way forward is to file a bug against mozilla-central and set the pref to true to make the test pass on comm-central and mozilla-central?

m-c doesn't need that. And rather than editing a single test, you should set it to true in comm-central for TB like it is for firefox.

Well, "need" is relative. m-c needs it addressed before you finally remove the pref altogether, since the test needs it. It's just that you don't notice it at the moment due to bug 1168178.

Comment 14

[Magnus Melin [:mkmelin]]

Actually, I'm confused now. Isn't it the case that it works only with false atm?

Comment 15

[John Bieling (:TbSync)]

(In reply to Magnus Melin [:mkmelin] from comment #14)

Actually, I'm confused now. Isn't it the case that it works only with false atm?

It needs true to pass. I verified with building Firefox locally with my patch. But it looks like we should switch the pref for us and see how bad we get burned and clean up.

Edit: But I sure would like to understand what that pref actually does :-)

Comment 16

[Intermittent Failures Robot]

33 failures in 554 pushes (0.06 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 33

Platform and build breakdown:

• macosx1015-64-qr: 6
  • debug: 3
  • opt: 3
• linux1804-64-qr: 6
  • opt: 3
  • debug: 3
• windows10-32-2004-qr: 6
  • opt: 3
  • debug: 3
• linux1804-64-shippable-qr: 3
  • opt: 3
• windows10-64-2004-qr: 4
  • opt: 3
  • debug: 1
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 3
  • opt: 3
• windows10-32-2004-shippable-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1752090&startday=2022-01-31&endday=2022-01-31&tree=all

Comment 17

[Intermittent Failures Robot]

24 failures in 574 pushes (0.042 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 24

Platform and build breakdown:

• linux1804-64-qr: 4
  • debug: 2
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows10-32-2004-qr: 4
  • debug: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• windows10-64-2004-qr: 4
  • debug: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 2
  • opt: 2
• macosx1015-64-qr: 4
  • debug: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1752090&startday=2022-02-01&endday=2022-02-01&tree=all

Comment 18

[John Bieling (:TbSync)]

Attachment: Bug 1752090 - Enable extensions.webextensions.background-delayed-startup. r=mkmelin

Comment 19

[John Bieling (:TbSync)]

So it looks like we do not get burned:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=72a8cda932f4d075febfca74dff997726c6a67bb

There are a few tests failing, but I believe those to be not new.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/afa904374ea2
Enable extensions.webextensions.background-delayed-startup. r=mkmelin

Comment 21

[Intermittent Failures Robot]

66 failures in 3165 pushes (0.021 failures/push) were associated with this bug in the last 7 days.

This is the #7 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 66

Platform and build breakdown:

• macosx1015-64-qr: 12
  • debug: 6
  • opt: 6
• linux1804-64-qr: 12
  • opt: 6
  • debug: 6
• windows10-32-2004-qr: 11
  • opt: 6
  • debug: 5
• linux1804-64-shippable-qr: 6
  • opt: 6
• windows10-64-2004-qr: 9
  • opt: 6
  • debug: 3
• windows10-64-2004-shippable-qr: 5
  • opt: 5
• macosx1015-64-shippable-qr: 6
  • opt: 6
• windows10-32-2004-shippable-qr: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1752090&startday=2022-01-31&endday=2022-02-06&tree=all