1753392 - Make delayed background startup actually work for Thunderbird.

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1753392 - Make delayed background startup actually work for Thunderbird. r=mkmelin

Depends on D136269

Comment 2

[John Bieling (:TbSync)]

I would like to backport this, so the pref works in TB91 already for add-on devs to test. It will be enforced only with TB98, but they should be able to test beforehand.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/47edea3756ec
Make delayed background startup actually work for Thunderbird. r=mkmelin

Comment 4

[John Bieling (:TbSync)]

Comment on attachment 9262060 [details]
Bug 1753392 - Make delayed background startup actually work for Thunderbird. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
Since ages we have renamed the "sessionstore-windows-restored" observer to "mail-tabs-session-restored". But the browserStartupPromise in toolkit is only checking the original m-c observer to trigger the delayed-webextension-startup. Until now we did not use delayed startup but are forced to enable it now. I want add-on devs to be able to test their add-ons with this new startup behaviour. In order for that to work, we need to notify the "sessionstore-windows-restored" observer.

User impact if declined:
extensions.webextensions.background-delayed-startup preference does not work

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None.

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9262060 [details]
Bug 1753392 - Make delayed background startup actually work for Thunderbird. r=mkmelin

This was included in the February 7 merge to beta, no uplift is needed.

Comment 6

[John Bieling (:TbSync)]

Attachment: Bug 1753392 - Make delayed background startup actually work for Thunderbird, take 2. r=mkmelin

Comment 7

[John Bieling (:TbSync)]

Try has not yet full finished for windows, but the crash was seen in debug builds and they are mostly green, so I think it is ok to land:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=6ee82427ab51ee7e837ad23e1b4f4bbf182af31f

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/31ba9ae19a82
Make delayed background startup actually work for Thunderbird, take 2. r=mkmelin

Comment 9

[John Bieling (:TbSync)]

Comment on attachment 9262890 [details]
Bug 1753392 - Make delayed background startup actually work for Thunderbird, take 2. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
Bug 1752090 enforced delayed-webextension-startup on Daily. The first patch in this bug enabled this startup behaviour on Beta as well. However, we saw crashes which could be related to the notification of the "sessionstore-windows-restored" observer. This patch instead notifies the "extensions-late-startup" observer, which has no other receiver, is single-purposed and a better candidate.

User impact if declined:
Notifying the "sessionstore-windows-restored" observer could have negative side effects.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None that I can think of.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9262890 [details]
Bug 1753392 - Make delayed background startup actually work for Thunderbird, take 2. r=mkmelin

[Triage Comment]
Approved for beta

Comment 11

[John Bieling (:TbSync)]

Uplift note: The second patch in this bug modifies the first one, so both have to be uplifted.

Comment 12

[John Bieling (:TbSync)]

Comment on attachment 9262890 [details]
Bug 1753392 - Make delayed background startup actually work for Thunderbird, take 2. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
The delayed background startup does not work.

Testing completed (on c-c, etc.):
Is on beta for a while now.

Risk to taking this patch (and alternatives if risky):
None

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9262890 [details]
Bug 1753392 - Make delayed background startup actually work for Thunderbird, take 2. r=mkmelin

[Triage Comment]
Approved for ers91

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 91.8.1:
https://hg.mozilla.org/releases/comm-esr91/rev/1d1a31845758
https://hg.mozilla.org/releases/comm-esr91/rev/7f8aff1fea77