1752806 - Thunderbird crashes when saving an attachment from a newsgroup message

Status: RESOLVED WONTFIX

(MailNews Core :: Networking: NNTP, defect)

Description

[max]

Steps to reproduce:

I am trying to save attachment for the following message:
news://news.gmane.io:119/[e-mail]

• create a news account for news.gmane.io
• subscribe to gmane.emacs.orgmode group
• download 500 messages
• type "add support for" in quick filter
• select the message that starts the thread
  [PATCH] Add support for $…$ latex fragments followed by a dash
1/24/22 4:42 PM, Sébastien Miquel
• try to save the attachment

Actual results:

• thunderbird-98.0a1.en-US.linux-x86_64 crashes on start, so the steps are irrelevant. Environment: LXC container with ubuntu-21.10 impish on ubuntu-20.04 focal host.
• thunderbird-97.0b3 is unable to display this message, so it is impossible to save attachment (LXC container again)
• 1:91.5.0+build1-0ubuntu0.20.04.1 Ubuntu-20.04 system package crashes on attempt to download the attachment (host)

Expected results:

I expect that I should be able to save attachment.

P.S. I do not mind that the link obtained through "copy message location" context menu item will be useful to open the message again:

./thunderbird/thunderbird --class ThunderbirdBeta --profile ~/profile/tb-news 'news://news.gmane.io:119/[e-mail]'

Ideally the command above should be the only step to reproduce the issue with clean new profile. The following works in thunderbird-91 but requires editing of the link when list of messages has been downloaded for the group:

/thunderbird/thunderbird --class ThunderbirdBeta --profile ~/profile/tb-news 'mid:[e-mail]'

Comment 1

[Alfred Peters [:infofrommozilla]]

(In reply to max from comment #0)

Steps to reproduce:

I am trying to save attachment for the following message:
news://news.gmane.io:119/[e-mail]

• try to save the attachment

• thunderbird-98.0a1.en-US.linux-x86_64 crashes on start, so

The current Daily crashes because of Bug 1752752. But if you manage to start it without selecting an account, it starts fine.
Then I can save the attachment without problems.

• thunderbird-97.0b3 is unable to display this message, so it is impossible to save attachment (LXC container again)

I can see the message and can save the attachment.

• 1:91.5.0+build1-0ubuntu0.20.04.1 Ubuntu-20.04 system package crashes on attempt to download the attachment (host)

TB91.5.1: I can see the message and can save the attachment.

All versions tested on Windows 10.

Comment 2

[max]

Thank you for your attempts to reproduce the issue and for clarifying the problem with daily.

Unfortunately I have no access to a windows machine.

The issue with thunderbird-91 I previously observed in my primary profile. Actually I have seen it earlier with version 78. Recently Ubuntu package updated and I had a hope that it will gone away. Unfortunately it has not happened, another annoying issue appeared instead. At certain moment CPU consumption becomes 50% and it can stay at such level for a long time. I usually quit from thunderbird. It may take hours before it happens. I suspect that it may be related to animated progress bar in the status bar.

I will try version 97 later. I have tried to install 1:91.5.0+build1-0ubuntu0.21.10.1 system package to the LXC container with ubuntu-21.10 impish I previously used for beta and daily. A was able to save attachments from this news group til I selected the group for offline use in the account settings.

This time save attachment crash was not 100% reproducible, however I have managed to get it. I selected messages using "PATCH" quick filter. and tried to save several ones. However first attempt to save attachment causes appearance of animated status bar and raised CPU consumption. None of attachments were actually saved with enabled offline use.

I know, it is bad to mix issues within single report, but they may be related. It looks like a missed call to fulfill a promise or a race.

Comment 3

[max]

Today I do not see any problem with thunderbird-97.0b3. The problem with this version I have faced yesterday to some sense was similar to the case when fetching of some message fails due to temporary network problem, so later it is shown as blank. However I made some attempts to repeat from more clear state. Today I tried to temporary block network using firewall, but I should repeat experiments using DROP instead of REJECT rule.

With thunderbird 1:91.5.0+build1-0ubuntu0.21.10.1 I have not seen crashes today (at least with test profiles), however problem with downloading of attachments persists:

• subscribe to gmane.emacs.orgmode at news.gmane.io
• select this news group for offline use in account settings
• there is a recent thread with 35 patches (use "PATCH" quick filter)
• try to save patches attached to messages in this thread.
• sometimes I can not save even single attachments, maybe it is better to try several ones.

Just animated progress bar in the status bar and to files...

Comment 4

[max]

Created Bug #1753195 for network progress bar that heats CPU making fan noisy (issue is mentioned in previous comments). It is really annoying for 91.5 and even switching to offline does not help. In 97.0b3 it is more subtle, but still may appear.

Comment 5

[max]

I have managed to reproduce with current daily (99a1) the issue I originally faced with beta (97.0b3): blank message area

• Ensure a clean profile mkdir -p ~/profile/tb-news-daily/
• thunderbird/thunderbird --profile ~/profile/tb-news-daily
• Since I suspected particular message I tried to open it directly: thunderbird/thunderbird --profile ~/profile/tb-news-daily 'news://news.gmane.io:119/f0597d96-a287-2c48-7897-6b8737c95217%40posteo.eu' Notice that URI must have @ encoded as %40, so Bug #1756126 may be related to some confusion of @ and %40 in some internal caches. The URI must not have group name otherwise thunderbird will send group-name/Message-ID as article ID instead of just Message-ID.
• Reject startup wizard
• Create a news account for news.gmane.io
• Notice that first attempt to open the message from CLI must be before subscribing to the news group
• subscribe to gmane.emacs.orgmode
• download 500 messages
• type "add support for" in quick filter
• select the message that starts the thread [PATCH] Add support for $…$ latex fragments followed by a dash 1/24/22 4:42 PM, Sébastien Miquel

Message pane appears blank

Comment 6

[Wayne Mery (:wsmwk)]

If you still crash, can you get a stacktrace with symbols?
FWIW, another current linux crash is Bug 1751142 Thunderbird crashes due to failed memory allocation, or hangs

Comment 7

[max]

(In reply to Wayne Mery (:wsmwk) from comment #6)

If you still crash,

Since I disabled offline storage for my main profile, my current greatest pain point is the Bug #1757146

can you get a stacktrace with symbols?

• Enable offline storage for a newsgroup
• Find a message with an attachment (for gmane.emacs.orgmode apply filter "PATCH")
• Try to save the attachment
• File is not saved
• Try to save it again
• Crash

For Ubuntu-21.10 system package:

#0  nsMsgLineStreamBuffer::ReadNextLine (this=0x0, aInputStream=0x7fffceafb358, aNumBytesInLine=@0x7fffffff9ad4: 0, aPauseForMoreData=@0x7fffffff9ad3: false, prv=0x0, addLineTerminator=false)
    at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/comm/mailnews/base/src/nsMsgLineBuffer.cpp:216
#1  0x00007ffff138f273 in nsNNTPProtocol::NewsResponse (this=this@entry=0x7fffd011e400, inputStream=inputStream@entry=0x7fffceafb358, length=<optimized out>) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/comm/mailnews/news/src/nsNNTPProtocol.cpp:1248
#2  0x00007ffff1395865 in nsNNTPProtocol::ProcessProtocolState (this=0x7fffd011e400, url=<optimized out>, inputStream=0x7fffceafb358, sourceOffset=<optimized out>, length=<optimized out>)
    at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/comm/mailnews/news/src/nsNNTPProtocol.cpp:3979
#3  0x00007ffff11ae982 in nsMsgProtocol::OnDataAvailable (this=0x7fffd011e400, request=<optimized out>, inStr=0x7fffffff9ad4, sourceOffset=140737488329427, count=0) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/comm/mailnews/base/src/nsMsgProtocol.cpp:300
#4  0x00007fffed95f3da in nsInputStreamPump::OnStateTransfer (this=this@entry=0x7fffdd0aa030) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/netwerk/base/nsInputStreamPump.cpp:532
#5  0x00007fffed95eef8 in nsInputStreamPump::OnInputStreamReady (this=0x7fffdd0aa030, stream=<optimized out>) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/netwerk/base/nsInputStreamPump.cpp:377
#6  0x00007fffed8351f4 in mozilla::SlicedInputStream::OnInputStreamReady (this=0x7fffd07c42e0, aStream=<optimized out>) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/io/SlicedInputStream.cpp:416
#7  0x00007fffed84d6dc in nsInputStreamReadyEvent::Run (this=0x7fffcedc12e0) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/io/nsStreamUtils.cpp:94
#8  0x00007fffed87fdae in mozilla::RunnableTask::Run (this=0x7fffd2fb4100) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/threads/TaskController.cpp:502
#9  0x00007fffed86cfd1 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal (this=this@entry=0x7fffebd3cd20, aProofOfLock=...) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/threads/TaskController.cpp:805
#10 0x00007fffed86c3d7 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal (this=this@entry=0x7fffebd3cd20, aProofOfLock=...) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/threads/TaskController.cpp:641
#11 0x00007fffed86c5cf in mozilla::TaskController::ProcessPendingMTTask (this=0x7fffebd3cd20, aMayWait=false) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/threads/TaskController.cpp:425
#12 0x00007fffed881382 in mozilla::TaskController::InitializeInternal()::$_0::operator()() const (this=<optimized out>) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/threads/TaskController.cpp:135
#13 mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() (this=<optimized out>) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/threads/nsThreadUtils.h:532
#14 0x00007fffed8764a4 in nsThread::ProcessNextEvent (this=0x7ffff783b580, aMayWait=false, aResult=0x7fffffffcef7) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/threads/nsThread.cpp:1152
#15 0x00007fffed87a246 in NS_ProcessNextEvent (aThread=0x0, aThread@entry=0x7ffff783b580, aMayWait=false) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/xpcom/threads/nsThreadUtils.cpp:466
#16 0x00007fffeddea2c8 in mozilla::ipc::MessagePump::Run (this=0x7fffebd13400, aDelegate=0x7ffff7862200) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/ipc/glue/MessagePump.cpp:85
#17 0x00007fffedda2ed8 in MessageLoop::RunInternal (this=0x7fffceafb358) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/ipc/chromium/src/base/message_loop.cc:331
#18 MessageLoop::RunHandler (this=0x7fffceafb358) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/ipc/chromium/src/base/message_loop.cc:324
#19 MessageLoop::Run (this=0x7fffceafb358) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/ipc/chromium/src/base/message_loop.cc:306
#20 0x00007fffefe6c869 in nsBaseAppShell::Run (this=0x7fffebd12e80) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/widget/nsBaseAppShell.cpp:137
#21 0x00007ffff1021dc2 in nsAppStartup::Run (this=0x7fffe72557e0) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/toolkit/components/startup/nsAppStartup.cpp:273
#22 0x00007ffff10e8fc5 in XREMain::XRE_mainRun (this=this@entry=0x7fffffffd210) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/toolkit/xre/nsAppRunner.cpp:5249
#23 0x00007ffff10e99a0 in XREMain::XRE_main (this=this@entry=0x7fffffffd210, argc=argc@entry=5, argv=argv@entry=0x7fffffffe4b8, aConfig=...) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/toolkit/xre/nsAppRunner.cpp:5434
#24 0x00007ffff10e9cb0 in XRE_main (argc=-827346088, argv=0x7fffffff9ad4, aConfig=...) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/toolkit/xre/nsAppRunner.cpp:5493
#25 0x0000555555560188 in do_main (argc=-827346088, argv=0x7fffffffe4b8, envp=<optimized out>) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/comm/mail/app/nsMailApp.cpp:229
#26 main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at /build/thunderbird-PGjRpF/thunderbird-91.5.0+build1/comm/mail/app/nsMailApp.cpp:368

Comment 8

[max]

I have filed the Bug #1758097 for an issue I originally faced for version 97 beta and described later for current 99 daily in the comment #5.

Comment 9

[WaltS48 [:walts48]]

• Created the news.gmane.org account in my 91.6.2 supplied by Fedora Linux
• Subscribed to the gmane.emacs.orgmode group
• Had to download 1000 messages
• Typed "add support for" in quick filter
• Selected the message that starts the thread
  [PATCH] Add support for $…$ latex fragments followed by a dash
  1/24/22 4:42 PM, Sébastien Miquel
• Tried to save the attachment
• The attachment was successfully saved.

Also works in the Thunderbird supplied 91.7.0.

This bug report states Version: 91, but the description and following comments mention beta and daily versions. Should I test those?

Maybe a Windows only problem?

Comment 10

[max]

(In reply to WaltS48 [:walts48] from comment #9)

• Created the news.gmane.org account in my 91.6.2 supplied by Fedora Linux
• Subscribed to the gmane.emacs.orgmode group
• Had to download 1000 messages
• Typed "add support for" in quick filter
• Selected the message that starts the thread

WaltS48, you have missed an important step specified in the comment #3

• select this news group for offline use in account settings

I have not tried 91.6 yet though. I was not aware that it is important when I was filing this bug and I was confused by other problems in newer versions. I enabled offline storage due to issues similar to the Bug #1757904 and the Bug #1758100, but for version 91 and earlier. Some time after I realized that I faced another bunch of bugs like this one and the Bug #1757146.

This bug report states Version: 91, but the description and following comments mention beta and daily versions. Should I test those?

Accordingly to Alfred Peters the original problem with daily was the Bug #1752752. Behavior I faced with beta was caused by the Bug #1758097, see comment #5 and comment #8.

Latest versions have another JS-based implementation of NNTP so they have other bugs. I have not managed to reproduce this one with thunderbird-99 unless I disable mailnews.nntp.jsmodule.

Maybe a Windows only problem?

I reported this issue for the system package shipped for Ubuntu-20.04 focal LTS

Comment 11

[max]

Reproduced with 91.7.0 when the following step is performed before switching to the news group

• select this news group for offline use in account settings

Notice that thunderbird crashes on second attempt to save the attachment.

Comment 12

[WaltS48 [:walts48]]

(In reply to max from comment #11)

Reproduced with 91.7.0 when the following step is performed before switching to the news group

• select this news group for offline use in account settings

Notice that thunderbird crashes on second attempt to save the attachment.

Sorry, I missed that in the original STR which I followed.

Comment 13

[WaltS48 [:walts48]]

I still can't reproduce crashing on saving the attachment after selecting the newsgroup for offline storage in the accounts Synchronization & Storage settings. Saved it several times in each test.

Tested with 91.7.0, 99.0b1 and 100a1 on Windows 10 with a test profile and only the newsgroup account.
Did the same on Fedora 35 Workstation with their 91.6.2, and the 91.7.0, 99.0b1 and 100.0a1 from Thunderbird.

Comment 14

[max]

(In reply to WaltS48 [:walts48] from comment #13)

I still can't reproduce crashing on saving the attachment after selecting the newsgroup for offline storage in the accounts Synchronization & Storage settings. Saved it several times in each test.

Tested with 91.7.0, 99.0b1 and 100a1 on Windows 10 with a test profile and only the newsgroup account.
Did the same on Fedora 35 Workstation with their 91.6.2, and the 91.7.0, 99.0b1 and 100.0a1 from Thunderbird.

To reproduce with thunderbird-99 or 100 you need to disable mailnews.nntp.jsmodule. I do not have windows instances to test.

I just have tried Fedora-Workstation-Live-x86_64-35-1.2.iso as a live image in Qemu. I can reproduce crash with thunderbird-91.7.0-1.fc35 and with thinderbird-91.7.0 downloaded from the thunderbird site

• Initial state: no thunderbird profile.
• Tried to run thunderbird with no CLI options and with just created directory --profile ~/thunderbird-91.
• Close default wizard.
• Create a news account, user "tst", email "liveuser@lcl", server news.gmane.io.
• Subscribe to the gmane.emacs.orgmode group.
• Download 500 messages.
• Select the news group for offline use.
• Filter "patch" messages.
• Find a message with a patch as an attachment.
• Click "save" (tried default home directory and /tmp) - file is not saved.
• Click "save" again - thunderbird crashes.

Comment 15

[Alfred Peters [:infofrommozilla]]

(In reply to max from comment #14)

To reproduce with thunderbird-99 or 100 you need to disable mailnews.nntp.jsmodule.

• Download 500 messages.
• Select the news group for offline use.
• Filter "patch" messages.
• Find a message with a patch as an attachment.
• Click "save" (tried default home directory and /tmp) - file is not saved.
• Click "save" again - thunderbird crashes.

Yes, now I can confirm the bug as well.

https://crash-stats.thunderbird.net/report/bp-cccd33cc-18ad-4800-9f5e-2e98f1220319

The use of the Save button is essential. The context menu of the attachment allows you to save it without any problems.

Comment 16

[WaltS48 [:walts48]]

(In reply to max from comment #14)

(In reply to WaltS48 [:walts48] from comment #13)

I still can't reproduce crashing on saving the attachment after selecting the newsgroup for offline storage in the accounts Synchronization & Storage settings. Saved it several times in each test.

Tested with 91.7.0, 99.0b1 and 100a1 on Windows 10 with a test profile and only the newsgroup account.
Did the same on Fedora 35 Workstation with their 91.6.2, and the 91.7.0, 99.0b1 and 100.0a1 from Thunderbird.

To reproduce with thunderbird-99 or 100 you need to disable mailnews.nntp.jsmodule. I do not have windows instances to test.

Apologies, I must have missed that step in the STR's.

I don't know why I would want to disable something implemented in the 96 beta when we should be testing with the preference enabled, since it is the new implementation.

Glad Alfred could reproduce it for you with mailnews.nntp.jsmodule disabled.

Comment 17

[Alfred Peters [:infofrommozilla]]

• Create a news account, user "tst", email "liveuser@lcl", server news.gmane.io.

• Filter "patch" messages.

It is not releated to this server nor to this file type.

I have posted an example in mozilla.test. With this the bug can be reproduced also.

| Message-ID: <[e-mail]>
| Subject: Post with Attachment
| From: Alfred Peters
| Newsgroups: mozilla.test
| Date: Sat, 19 Mar 2022 16:28:43 +0100

Comment 18

[max]

(In reply to WaltS48 [:walts48] from comment #16)

I don't know why I would want to disable something implemented in the 96 beta when we should be testing with the preference enabled, since it is the new implementation.

Glad Alfred could reproduce it for you with mailnews.nntp.jsmodule disabled.

I reported this bug namely for the version 91 since I am afraid that for the latest releases most probable resolution is WONTFIX due to changed default implementation of NNTP stack. At the same time it is painful for the ESR release since in both variants with enabled or disabled offline storage thunderbird works unreliable, most annoying bugs are different though.

(In reply to Alfred Peters from comment #15)

The use of the Save button is essential. The context menu of the attachment allows you to save it without any problems.

I can not confirm such observation for thunderbird-91 on Linux.

Comment 19

[max]

Is this bug still "UNCONFIRMED" despite 2 stack traces have been reported: thunderbird-100 on windows and thunderbird-91 on linux?

P.S. Let me stress it: it is necessary to try to save a same attachment twice and offline storage for the newsgroup must be enabled.

Comment 20

[max]

(In reply to Alfred Peters from comment #17)

• Create a news account, user "tst", email "liveuser@lcl", server news.gmane.io.

I was trying to be precise since WaltS48 was unable to reproduce.

• Filter "patch" messages.

It is not releated to this server nor to this file type.

The intention was to not diverge too much from the original report. That time I suspected particular message, so I specified a recipe how to find a suitable message in the same active enough news group. Thunderbird does not show the attachment icon for newsgroup articles till a message is fetched (and sometimes does not do it even after the message is displayed).

Comment 21

[Wayne Mery (:wsmwk)]

Does this still happen in version 102?

Comment 22

[max]

(In reply to Wayne Mery (:wsmwk) from comment #21)

Does this still happen in version 102?

Yes, it does with when mailnews.nntp.jsmodule setting is disabled and off-line storage is enabled. Fortunately currently I do not need a workaround to download an attachment with the default value of mailnews.nntp.jsmodule.

• Initial state: no thunderbird profile.
• Disable mailnews.nntp.jsmodule in config editor and restart Thunderbird.
• Close default wizard.
• Create a news account for the news.gmane.io server.
• Subscribe to the gmane.emacs.orgmode group.
• Download 500 messages.
• Select the news group for offline use.
• Filter "patch" messages.
• Find a message with a patch as an attachment (messages starting thread).
• Click "save" file is not saved.
• Click "save" again
• thunderbird crashes.

Comment 23

[Wayne Mery (:wsmwk)]

Thanks for the update. I had forgotten this doesn't happen with mailnews.nntp.jsmodule enabled. So I think it is unlikely we would invest time to fix this.

Comment 24

[Magnus Melin [:mkmelin]]

Yeah this ship sailed.