1752829 - Make decorative noodles and logo style configurable in AboutWelcome

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Meg Viar [:mviar]]

This patch supports refactoring AboutWelcome.jsx to a common component that can replace the upgrade dialogue and Spotlight components.

This work helps set the stage for future patches and should not introduce any changes in UI or existing functionality.

Included work:

• Drafting a new JSON schema for the AboutWelcome configuration
• Add has_noodles option on configuration and support display of background noodles when this is set to true
• Add support for custom logo url and size
• Support configs with no background_url
• Determine if AboutWelcome's child components are rendered in about:welcome using the window location when conditional logic for that context is required

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1752829 - Make decorative noodles and logo style configurable in AboutWelcome

Comment 2

[Meg Viar [:mviar]]

Attachment: AboutWelcome.schema.json

First draft of updated JSON schema for AboutWelcome

Comment 3

[Meg Viar [:mviar]]

Attachment: AboutWelcome.schema.json

Updated AboutWelcome schema with changes relevant to this patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c75cbdfcdde8
Make decorative noodles and logo style configurable in AboutWelcome r=Mardak

Comment 5

[Meg Viar [:mviar]]

Note - on the try server, browser_aboutwelcome_rtamo.js isn't skipped and fails on Linux. This test should be skipped on Linux (see skip condition here).

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing browser chrome failures on browser_aboutwelcome_rtamo.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c75cbdfcdde8ee2224090176169791afb21d5a9e&selectedTaskRun=U_WxXWVbRG2uQMqA2RXGNw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=367728375&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/b072c513134910b2edc5c7ab47c6d6a1c87c8de4

[task 2022-02-13T16:55:55.195Z] 16:55:55     INFO - TEST-INFO | started process screentopng
[task 2022-02-13T16:55:56.436Z] 16:55:56     INFO - TEST-INFO | screentopng: exit 0
[task 2022-02-13T16:55:56.437Z] 16:55:56     INFO - Buffered messages logged at 16:55:49
[task 2022-02-13T16:55:56.438Z] 16:55:56     INFO - Entering test bound test_rtamo_aboutwelcome
[task 2022-02-13T16:55:56.438Z] 16:55:56     INFO - Buffered messages finished
[task 2022-02-13T16:55:56.438Z] 16:55:56     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js | Uncaught exception in test - Should render h2[data-l10n-id='return-to-amo-addon-title'] in RTAMO UI - timed out after 50 tries.
[task 2022-02-13T16:55:56.438Z] 16:55:56     INFO - Leaving test bound test_rtamo_aboutwelcome
[task 2022-02-13T16:55:56.440Z] 16:55:56     INFO - Entering test bound test_rtamo_over_experiments
[task 2022-02-13T16:55:56.441Z] 16:55:56     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-02-13T16:55:56.446Z] 16:55:56     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js | Uncaught exception in test - at resource://testing-common/sinon-7.2.7.js:3605 - TypeError: Attempted to wrap getAddonsByIDs which is already wrapped
[task 2022-02-13T16:55:56.446Z] 16:55:56     INFO - Stack trace:
[task 2022-02-13T16:55:56.447Z] 16:55:56     INFO - checkWrappedMethod@resource://testing-common/sinon-7.2.7.js:3605:21
[task 2022-02-13T16:55:56.454Z] 16:55:56     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3653:31
[task 2022-02-13T16:55:56.455Z] 16:55:56     INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2022-02-13T16:55:56.456Z] 16:55:56     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-02-13T16:55:56.456Z] 16:55:56     INFO - test_rtamo_over_experiments@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js:223:11
[task 2022-02-13T16:55:56.457Z] 16:55:56     INFO - handleTask@chrome://mochikit/content/browser-test.js:989:26
[task 2022-02-13T16:55:56.457Z] 16:55:56     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1061:18
[task 2022-02-13T16:55:56.458Z] 16:55:56     INFO - 
[task 2022-02-13T16:55:56.458Z] 16:55:56     INFO - --------------
[task 2022-02-13T16:55:56.459Z] 16:55:56     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3679:26
[task 2022-02-13T16:55:56.459Z] 16:55:56     INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2022-02-13T16:55:56.460Z] 16:55:56     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-02-13T16:55:56.460Z] 16:55:56     INFO - test_rtamo_aboutwelcome@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js:129:11
[task 2022-02-13T16:55:56.460Z] 16:55:56     INFO - handleTask@chrome://mochikit/content/browser-test.js:989:26
[task 2022-02-13T16:55:56.461Z] 16:55:56     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1061:18
[task 2022-02-13T16:55:56.461Z] 16:55:56     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1189:14
[task 2022-02-13T16:55:56.462Z] 16:55:56     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:978:14
[task 2022-02-13T16:55:56.462Z] 16:55:56     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1041:13
[task 2022-02-13T16:55:56.465Z] 16:55:56     INFO - Leaving test bound test_rtamo_over_experiments
[task 2022-02-13T16:55:56.467Z] 16:55:56     INFO - Entering test bound test_rtamo_primary_button_theme
[task 2022-02-13T16:55:56.468Z] 16:55:56     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-02-13T16:55:56.481Z] 16:55:56     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js | Uncaught exception in test - at resource://testing-common/sinon-7.2.7.js:3605 - TypeError: Attempted to wrap getAddonsByIDs which is already wrapped
[task 2022-02-13T16:55:56.481Z] 16:55:56     INFO - Stack trace:
[task 2022-02-13T16:55:56.482Z] 16:55:56     INFO - checkWrappedMethod@resource://testing-common/sinon-7.2.7.js:3605:21
[task 2022-02-13T16:55:56.482Z] 16:55:56     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3653:31
[task 2022-02-13T16:55:56.483Z] 16:55:56     INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2022-02-13T16:55:56.483Z] 16:55:56     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-02-13T16:55:56.483Z] 16:55:56     INFO - test_rtamo_primary_button_theme@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js:273:6
[task 2022-02-13T16:55:56.484Z] 16:55:56     INFO - handleTask@chrome://mochikit/content/browser-test.js:989:26
[task 2022-02-13T16:55:56.484Z] 16:55:56     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1061:18
[task 2022-02-13T16:55:56.484Z] 16:55:56     INFO - 
[task 2022-02-13T16:55:56.484Z] 16:55:56     INFO - --------------
[task 2022-02-13T16:55:56.485Z] 16:55:56     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3679:26
[task 2022-02-13T16:55:56.485Z] 16:55:56     INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2022-02-13T16:55:56.486Z] 16:55:56     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-02-13T16:55:56.486Z] 16:55:56     INFO - test_rtamo_aboutwelcome@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js:129:11
[task 2022-02-13T16:55:56.487Z] 16:55:56     INFO - handleTask@chrome://mochikit/content/browser-test.js:989:26
[task 2022-02-13T16:55:56.488Z] 16:55:56     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1061:18
[task 2022-02-13T16:55:56.488Z] 16:55:56     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1189:14
[task 2022-02-13T16:55:56.489Z] 16:55:56     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:978:14
[task 2022-02-13T16:55:56.489Z] 16:55:56     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1041:13
[task 2022-02-13T16:55:56.493Z] 16:55:56     INFO - Leaving test bound test_rtamo_primary_button_theme
[task 2022-02-13T16:55:56.493Z] 16:55:56     INFO - GECKO(5774) | console.debug: AboutWelcomeParent:
[task 2022-02-13T16:55:56.496Z] 16:55:56     INFO - GECKO(5774) |   Terminate reason is welcome-tab-closed
[task 2022-02-13T16:55:56.497Z] 16:55:56     INFO - GECKO(5774) | MEMORY STAT | vsize 11595MB | residentFast 553MB | heapAllocated 277MB
[task 2022-02-13T16:55:56.502Z] 16:55:56     INFO - TEST-OK | browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js | took 5571ms

Comment 7

[Meg Viar [:mviar]]

The test_aboutwelcome_rtamo test is failing on Linux, but that's expected as it is only configured for Windows and OSx and meant to be skipped on Linux (see here). I can investigate why that test is not being skipped as specified.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76e05525f075
Make decorative noodles and logo style configurable in AboutWelcome r=Mardak

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/76e05525f075