1753885 - turn swipe to navigate back on for nightly on Windows

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement)

Description

[Timothy Nikkel (:tnikkel)]

Disabled everywhere in bug 1751124 but it's in good enough shape to still get testing in nightly at least.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1753885. Enable swipe to navigate on Windows on nightly only. r?hiro

Disabled everywhere in bug 1751124 but it's in good enough shape to still get testing in nightly at least.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e1d8d29428d
Enable swipe to navigate on Windows on nightly only. r=hiro

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4e1d8d29428d

Comment 4

[Donal Meehan [:dmeehan]]

Should we mention this in our nightly release notes?

Comment 5

[Botond Ballo [:botond]]

(In reply to Donal Meehan [:dmeehan] from comment #4)

Should we mention this in our nightly release notes?

I didn't realize we had nightly release notes! Yes, I think it would be a good idea to mention. Suggested wording: "Page navigation (back or forward) can now be triggered using a horizontal two-finger swipe gesture on Windows touchpads." Let me know if you need any other info.

Comment 6

[Timothy Nikkel (:tnikkel)]

You should note though that this feature has been on in nightly since bug 1348786 landed on 2022-01-05. It was briefly disabled in bug 1751124 on 2022-02-02, until this bug on 2022-02-07.

Comment 7

[Donal Meehan [:dmeehan]]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]: No
[Suggested wording]: Page navigation (back or forward) can now be triggered using a horizontal two-finger swipe gesture on Windows touchpads.
[Links (documentation, blog post, etc)]:

Comment 8

[Donal Meehan [:dmeehan]]

Note add to https://www.mozilla.org/firefox/99.0a1/releasenotes/

Comment 9

[Timothy Nikkel (:tnikkel)]

(In reply to Donal Meehan [:dmeehan] from comment #8)

Note add to https://www.mozilla.org/firefox/99.0a1/releasenotes/

I would classify this under New instead of Fixed.

Comment 10

[Donal Meehan [:dmeehan]]

(In reply to Timothy Nikkel (:tnikkel) from comment #9)

(In reply to Donal Meehan [:dmeehan] from comment #8)

Note add to https://www.mozilla.org/firefox/99.0a1/releasenotes/

I would classify this under New instead of Fixed.

Thanks. The category has been changed to New.

Comment 11

[gterras]

This fix seems to trigger an undesired behavior with a static element inside (and above) a element with a scrollbar, see https://jsfiddle.net/8vcnjy40/13/

Here you can scroll the underlying element by hovering its scrollbar which is unexpected.

Comment 12

[Timothy Nikkel (:tnikkel)]

That doesn't seem related to this bug? Can you file a new bug for that please, either cc me or put it in panning and zooming or mention the bug number here so I can find it. Thanks.

Comment 13

[gterras]

Sorry indeed wrong bug I've just reposted to https://bugzilla.mozilla.org/show_bug.cgi?id=1147847 feel free to delete it here.