1755093 - ./mach bootstrap fails with "IndexError: list index out of range" in ['artifact', 'toolchain', '--bootstrap', '--from-build', 'win64-clang-tidy'] (./mach configure also broken)

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Would you like to run a few configuration steps to ensure Git is
optimally configured? (Yn): n
checking for vcs source checkout... git
checking for a shell... C:/dev/mozilla/mozilla-build-3_4/msys/bin/sh.exe
checking for host system type... x86_64-pc-mingw32
WARNING: list index out of range
git: 'cinnabar' is not a git command. See 'git --help'.
Error running mach:

    ['artifact', 'toolchain', '--bootstrap', '--from-build', 'win64-clang-tidy']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file artifact| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

IndexError: list index out of range

  File "c:\dev\mozilla\gecko9\python\mozbuild\mozbuild\artifact_commands.py", line 380, in artifact_toolchain
    tasks = toolchain_task_definitions()
  File "c:\dev\mozilla\gecko9\python\mozbuild\mozbuild\toolchains.py", line 19, in toolchain_task_definitions
    toolchains = load_tasks_for_kind(params, "toolchain", root_dir=root_dir)
  File "c:\dev\mozilla\gecko9\taskcluster\gecko_taskgraph\generator.py", line 490, in load_tasks_for_kind
    for task in tgg.full_task_set
  File "c:\dev\mozilla\gecko9\taskcluster\gecko_taskgraph\generator.py", line 163, in full_task_set
    return self._run_until("full_task_set")
  File "c:\dev\mozilla\gecko9\taskcluster\gecko_taskgraph\generator.py", line 435, in _run_until
    k, v = next(self._run)
  File "c:\dev\mozilla\gecko9\taskcluster\gecko_taskgraph\generator.py", line 264, in _run
    parameters = self._parameters(graph_config)
  File "c:\dev\mozilla\gecko9\third_party\python\taskcluster_taskgraph\taskgraph\parameters.py", line 330, in get_parameters
    trust_domain=graph_config["trust-domain"],
  File "c:\dev\mozilla\gecko9\third_party\python\taskcluster_taskgraph\taskgraph\parameters.py", line 281, in load_parameters_file
    return Parameters(strict=strict, repo_root=repo_root, **overrides)
  File "c:\dev\mozilla\gecko9\third_party\python\taskcluster_taskgraph\taskgraph\parameters.py", line 128, in __init__
    kwargs = Parameters._fill_defaults(repo_root=repo_root, **kwargs)
  File "c:\dev\mozilla\gecko9\third_party\python\taskcluster_taskgraph\taskgraph\parameters.py", line 168, in _fill_defaults
    defaults.update(fn(repo_root))
  File "c:\dev\mozilla\gecko9\third_party\python\taskcluster_taskgraph\taskgraph\parameters.py", line 66, in _get_defaults
    project = repo_url.rsplit("/", 1)[1]
git: 'cinnabar' is not a git command. See 'git --help'.
Error running mach:

    ['boostrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file bootstrap| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

subprocess.CalledProcessError: Command '['c:\\Users\\jgilbert\\.mozbuild\\srcdirs\\gecko9-049f74f53434\\_virtualenvs\\mach\\Scripts\\python.exe', 'C:\\dev\\mozilla\\gecko9\\mach', 'artifact', 'toolchain', '--bootstrap', '--from-build', 'win64-clang-tidy']' returned non-zero exit status 1.

  File "c:\dev\mozilla\gecko9\python\mozboot\mozboot\mach_commands.py", line 43, in bootstrap
    bootstrapper.bootstrap(command_context.settings)
  File "c:\dev\mozilla\gecko9\python\mozboot\mozboot\bootstrap.py", line 367, in bootstrap
    self.maybe_install_private_packages_or_exit(application)
  File "c:\dev\mozilla\gecko9\python\mozboot\mozboot\bootstrap.py", line 241, in maybe_install_private_packages_or_exit
    self.instance.ensure_clang_static_analysis_package()
  File "c:\dev\mozilla\gecko9\python\mozboot\mozboot\mozillabuild.py", line 210, in ensure_clang_static_analysis_package
    self.install_toolchain_static_analysis(static_analysis.WINDOWS_CLANG_TIDY)
  File "c:\dev\mozilla\gecko9\python\mozboot\mozboot\base.py", line 387, in install_toolchain_static_analysis
    self.install_toolchain_artifact_impl(clang_tools_path, toolchain_job)
  File "c:\dev\mozilla\gecko9\python\mozboot\mozboot\base.py", line 445, in install_toolchain_artifact_impl
    subprocess.check_call(cmd, cwd=str(install_dir))
  File "c:\dev\mozilla\mozilla-build-3_4\python3\lib\subprocess.py", line 363, in check_call
    raise CalledProcessError(retcode, cmd)

This basically looks like bug 1753047, but failing in splitting the repo url at '/'.
Which would make sense, because not all valid git urls have slashes. :)

$ git remote -v
github  [e-mail]:jdashg/gecko-cinn.git (fetch)
github  [e-mail]:jdashg/gecko-cinn.git (push)
origin  [e-mail]:gecko1 (fetch)
origin  [e-mail]:gecko1 (push)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1755093 - Support repo_url with no slash.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: busted ./mach configure

This also looks like it was what was preventing my `./mach configure` somehow?

Comment 3

[Kelsey Gilbert [:jgilbert]]

(dupe)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/954c4d8bbd3b
Support repo_url with no slash. r=ahal

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/954c4d8bbd3b