1755828 - Add a Learn More link to the top pick checkbox in the preferences UI

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

The Top pick checkbox in the preferences UI has been finalized, and the spec calls for a Learn More link next to the checkbox. See the Figma, "Top pick proposal
for Firefox 99 - preferences" section.

I created SUGGEST-245 to track creation of the SUMO page. At this time, we don't know what the page's slug will be. For now, we can use anything, and we can land a small patch later to use the final slug. I would suggest top-pick for now.

To generate the URL, we can use the method shown here:

  Services.urlFormatter.formatURLPref("app.support.baseURL") + "top-pick"

Comment 1

[Drew Willcoxon :adw]

Daisuke, would you be interested in this?

Comment 2

[Daisuke Akatsuka (:daisuke)]

Yap, let me take this one. Thanks!

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1755828: Add a Learn more link to the top pick checkbox.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38eaecc66fbb
Add a Learn more link to the top pick checkbox. r=preferences-reviewers,adw,fluent-reviewers,mstriemer

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/38eaecc66fbb

Comment 6

[Drew Willcoxon :adw]

STR for QA:

1. Enable Firefox Suggest
2. Enable best match by setting browser.urlbar.bestMatch.enabled to true
3. Open about:preferences#privacy and verify the "Top pick" checkbox has a "Learn more" link next to it (see Figma spec if necessary, but note the link is underlined in the spec, which is not correct; it should not be underlined)
4. Click the Learn more link and verify a SUMO link similar to the following opens in a new tab. It may be slightly different depending on locale and platform, but it should end in "top-pick". Also note that this page hasn't been created yet so you will get an error page: https://support.mozilla.org/1/firefox/99.0a1/Darwin/en-US/top-pick

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 99.0a1 (Build ID: 20220220215821) on Windows 10 x64. macOS 10.15.7 and Linux Mint 20.

• In order to verify this issue we have used the STR from comment 6.
• The "Learn more" link is correctly displayed in "about:preferences#privacy" beside the "Top Pick" option.
• The link redirects to a SUMO page as described in comment 6.