Closed Bug 1756656 Opened 2 years ago Closed 2 years ago

Remove preprocessor conditional from browser/themes/shared/ctrlTab.inc.css

Categories

(Firefox :: Theme, task, P3)

Product:
Firefox
Component:
Theme
Platform:
Desktop
All
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox99 --- wontfix
firefox100 --- fixed

People

(Reporter: Gijs, Assigned: sclements)

References

Details

(Whiteboard: [fidefe-2022-mr1-css-linting])

Attachments

(1 file)

Bug 1756656 - Remove ifdefs from ctrlTab.inc.css r=Gijs
48 bytes, text/x-phabricator-request
Details | Review

There are some mac/non-mac conditions. We can use a media query instead.

Points: --- → 1
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2432d45a70b
Remove ifdefs from ctrlTab.inc.css r=Gijs

Backed out for causing mochitest failures on browser_parsable_css.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for resource://gre-resources/html.css: Unexpected token ‘not(’ in media list
Flags: needinfo?(sclements)

I don't see anything wrong with this one. I think it must've been the commit that landed before it bug 1756655?

Flags: needinfo?(sclements)

(In reply to Sarah Clements [:sclements] from comment #4)

I don't see anything wrong with this one. I think it must've been the commit that landed before it bug 1756655?

I agree - feel free to re-land this patch as-is.

Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f90fa65015dc
Remove ifdefs from ctrlTab.inc.css r=Gijs

https://hg.mozilla.org/mozilla-central/rev/f90fa65015dc

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.