1757488 - Disable best match blocking

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Product says we should disable blocking for the MVP.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1757488 - Disable best match blocking.

This puts blocking behind a preference. It sounds like we may want to enable
blocking again later, so I don't want to remove all the code for that yet, and
we should continue to run the related tests so we don't miss regressions.

This also modifies the test so it checks the key shortcut (Shift-Delete) when
blocking is both enabled and disabled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1cbd0070dd0
Disable best match blocking. r=daisuke

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_bestMatch.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f2b86070521ae674f07383ed9f979bbd41f32c0e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=cBePcj-AQ4yOsP4lbOzoLg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a1cbd0070dd06512649b9660e919b06d010576c6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=369528306&repo=autoland&lineNumber=5158

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d6ced577f1e
Disable best match blocking. r=daisuke

Comment 5

[Drew Willcoxon :adw]

STR for QA:

This bug removes the block/thumbs-down button from best matches.

1. Enable Firefox Suggest
2. Enable best match by setting browser.urlbar.bestMatch.enabled to true
3. Type amazon to trigger an Amazon best match
4. Verify the best match row does not have thumbs-down button. It should still have the ? help button

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6d6ced577f1e

Comment 7

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Nightly 99.0a1 (Build ID: 20220302065857) on Windows 10 x64, macOS 10.15.7 and Linux Ubuntu 20.04 x64.

• In order to verify this issue we have used the STR from comment 5.
• The thumbs-down button is no longer displayed in the Best Match section.
• Only the ? Help button is displayed in the right side of the Best Match result.