1759504 - Implement text recognition component on macOS.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Comment 1

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

Attachment: Bug 1759504 - Implement text recognition component in macOS. r=emilio,nordzilla

Comment 2

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

Attachment: Bug 1759504 - Prototype a menu button click demo for text recognition r=emilio,nordzilla

Depends on D140874

Comment 3

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

Attachment: Bug 1759504 - Fill in the quad points for text recognition r=emilio,nordzilla

Depends on D140875

Comment 4

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

Attachment: Bug 1759504 - Prototype a UAWidget for TextRecognition r=emilio,nordzilla

Note this is an experiment. It seems like this could all happen from the C++
side of things. The issues is getting the width of the parent img tag, and have
layout happen relative to the img above it.

Depends on D143421

Comment 5

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

Attachment: Bug 1759504 - Return the ImageText results from recognizeCurrentImageText r=emilio,nordzilla

Depends on D143422

Comment 6

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

Attachment: Bug 1759504 - Put the text recognition UI behind an experimental feature r=emilio,nordzilla

Depends on D143423

Comment 7

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

Attachment: Bug 1759504 - Drive by fix of Feature Gate docs r=emilio,nordzilla

Depends on D146829

Comment 8

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

I have patches up for review, but these are blocked by Bug 1696504 and Bug 1743170. Hopefully that will land soon-ish, otherwise I will work on adding the proper ifdefs to land this code. I would like to get it in to review sooner rather than later.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a21b8153ca2a
Implement text recognition component in macOS. r=emilio,nordzilla
https://hg.mozilla.org/integration/autoland/rev/b5f762f1f22e
Prototype a menu button click demo for text recognition r=fluent-reviewers,emilio,nordzilla,flod
https://hg.mozilla.org/integration/autoland/rev/a0b089fb747b
Fill in the quad points for text recognition r=emilio,nordzilla
https://hg.mozilla.org/integration/autoland/rev/dc1be2f0e0b6
Prototype a UAWidget for TextRecognition r=emilio,nordzilla
https://hg.mozilla.org/integration/autoland/rev/b9beaecf9708
Return the ImageText results from recognizeCurrentImageText r=emilio,nordzilla
https://hg.mozilla.org/integration/autoland/rev/a14a874c57b0
Put the text recognition UI behind an experimental feature r=emilio,nordzilla,fluent-reviewers,preferences-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/d1f1173aecfc
Drive by fix of Feature Gate docs r=nordzilla,preferences-reviewers,jaws

Comment 10

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing Android build bustages on NodeListBinding.cpp

Backout link : https://hg.mozilla.org/integration/autoland/rev/52946cd9af9f2c16417d48f163eb9c0db884015a

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=android%2C4.1%2Cx86%2Cdebug%2Cbuild-android-x86-fuzzing%2Fdebug%2Cbf&revision=d1f1173aecfc36ed24658e783633bf35ed5ad8d3&selectedTaskRun=KvnkXT1GTAmLazQ_XzLttg.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=380046893&repo=autoland&lineNumber=29945

Failure line :
/builds/worker/workspace/obj-build/dom/bindings/NodeListBinding.cpp:54:15: error: no matching function for call to 'StrongOrRawPtr

Comment 11

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

:emilio do you have any idea on what's causing this build error on android fuzzing builds? It's the only build that is affecting. I have narrowed it down to this change in my patch stack: https://hg.mozilla.org/try/rev/6e41c66c1f3bf91e1767f87d8244646974eadb31

From: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=96167f081ca9d7e82cc6fe91a2cb7c62009607ec

I'm not familiar with the bindings code enough to have a clue what the issue. At the very least I could split this patch out to a separate bug, since the feature still works without it. I could also delete and push to try to find the specific line that's causing the issue.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

This is a pre-existing bug in the bindings / bindings configuration. The issue is that nsINodeList.h doesn't include nsIContent.h, and the bindings don't know that nsIContent is a subclass of nsINode. So including nsINode.h and nsINodeList.h is not enough for nsINodeList::IndexerGetter to compile, because the later returns nsIContent*

I can see multiple ways to fix this. The easiest is probably this:

diff --git a/dom/bindings/Bindings.conf b/dom/bindings/Bindings.conf
index 636d9c805976f..85345834a7555 100644
--- a/dom/bindings/Bindings.conf
+++ b/dom/bindings/Bindings.conf
@@ -591,6 +591,7 @@ DOMInterfaces = {
 
 'Node': {
     'nativeType': 'nsINode',
+    'headerFile': 'nsIContent.h',
 },
 
 'NodeIterator': {

There's also the alternative to do something like this does. I think that's probably more straight-forward.

Comment 13

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

Re-landing since Bug 1772562 is queued.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1ac61d8f49c
Implement text recognition component in macOS. r=emilio,nordzilla
https://hg.mozilla.org/integration/autoland/rev/cc5d236d3496
Prototype a menu button click demo for text recognition r=fluent-reviewers,emilio,nordzilla,flod
https://hg.mozilla.org/integration/autoland/rev/c4c054fbb489
Fill in the quad points for text recognition r=emilio,nordzilla
https://hg.mozilla.org/integration/autoland/rev/b137841d6fa5
Prototype a UAWidget for TextRecognition r=emilio,nordzilla
https://hg.mozilla.org/integration/autoland/rev/cae0a1f8474d
Return the ImageText results from recognizeCurrentImageText r=emilio,nordzilla
https://hg.mozilla.org/integration/autoland/rev/9a499e40799d
Put the text recognition UI behind an experimental feature r=emilio,nordzilla,fluent-reviewers,preferences-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/acf6d2bf1770
Drive by fix of Feature Gate docs r=nordzilla,preferences-reviewers,jaws

Comment 15

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b1ac61d8f49c
https://hg.mozilla.org/mozilla-central/rev/cc5d236d3496
https://hg.mozilla.org/mozilla-central/rev/c4c054fbb489
https://hg.mozilla.org/mozilla-central/rev/b137841d6fa5
https://hg.mozilla.org/mozilla-central/rev/cae0a1f8474d
https://hg.mozilla.org/mozilla-central/rev/9a499e40799d
https://hg.mozilla.org/mozilla-central/rev/acf6d2bf1770