1759559 - Implement "browsingContext.create" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

As discussed in the meeting today we want to leverage from this command to run individual navigation tests isolated in their own tab.

Comment 2

[Julian Descottes [:jdescottes]]

Note there is a pending discussion item for this command:

HTML’s window open steps depend on the "entry global object" and WebDriver’s New Window command depends on the "current browsing context". Given that we don’t have any such implicit context here, what OS window should new tabs be opened in?

meaning it's not clear in which window new tabs should be opened. It might make sense to use the topmost window?

Comment 3

[Julian Descottes [:jdescottes]]

See also https://github.com/w3c/webdriver-bidi/pull/153 for a proposal to add an optional context argument, which addresses the issue above.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [webdriver-bidi] Implement browsingContext.create command

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [webdriver-bidi] Implement browsingContext.create command

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [wdspec] Add create command to browsing context module of WebDriver BiDi client

Depends on D143648

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [wdspec] Add webplatform tests for browsingContext.create

Depends on D143649

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [webdriver-bidi] Add context parameter to browsingContext.create command

Depends on D143650

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [wdspec] Support context parameter context for browsing context create

Depends on D143651

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [wdspec] Update wdspec tests for the browsingContext.create context parameter

Depends on D143652

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [webdriver-bidi] Add gecko specific webdriver test for browsingContext.create context argument

Depends on D143653

Comment 12

[Phabricator Automation]

Comment on attachment 9272188 [details]
Bug 1759559 - [webdriver-bidi] Add context parameter to browsingContext.create command

Revision D143651 was moved to bug 1765619. Setting attachment 9272188 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9272189 [details]
Bug 1759559 - [wdspec] Support context parameter context for browsing context create

Revision D143652 was moved to bug 1765619. Setting attachment 9272189 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9272190 [details]
Bug 1759559 - [wdspec] Update wdspec tests for the browsingContext.create context parameter

Revision D143653 was moved to bug 1765619. Setting attachment 9272190 [details] to obsolete.

Comment 15

[Phabricator Automation]

Comment on attachment 9272191 [details]
Bug 1759559 - [webdriver-bidi] Add gecko specific webdriver test for browsingContext.create context argument

Revision D143654 was moved to bug 1765619. Setting attachment 9272191 [details] to obsolete.

Comment 16

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [remote] Add focus and window parameters to TabManager.addTab

Update the addTab API to support BiDi's browsingContext.create, including the context argument

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14fc7214e077
[remote] Add focus and window parameters to TabManager.addTab r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/eebfe12bce78
[webdriver-bidi] Implement browsingContext.create command r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/0e85aff12e73
[wdspec] Add create command to browsing context module of WebDriver BiDi client r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/cac484b3adb8
[wdspec] Add webplatform tests for browsingContext.create r=webdriver-reviewers,whimboo

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33838 for changes under testing/web-platform/tests

Comment 19

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/14fc7214e077
https://hg.mozilla.org/mozilla-central/rev/eebfe12bce78
https://hg.mozilla.org/mozilla-central/rev/0e85aff12e73
https://hg.mozilla.org/mozilla-central/rev/cac484b3adb8

Comment 20

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham

Comment 22

[Julian Descottes [:jdescottes]]

Attachment: Bug 1759559 - [remote] Add reference context parameter to TabManager addTab

The update version of the browsingContext.create spec mentions that the new tab should be added right after the reference context when
provided. We need to extend TabManager.addTab in order to support this behavior:

Comment 23

[Phabricator Automation]

Comment on attachment 9298117 [details]
Bug 1759559 - [remote] Add reference context parameter to TabManager addTab

Revision D159121 was moved to bug 1765619. Setting attachment 9298117 [details] to obsolete.