1759572 - nsMultiplexInputStream::AsyncWaitLengthHelper should be threadsafe

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1759572 - AsyncLengthWaitHelper should be threadsafe, r=asuth!

This works only because the only implementation of nsIAsyncInputStreamLength
happened to only run on the current thread. Bug 1754004, changes this, and requires the reference to be threadsafe.

Depends on D141036

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nika, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Waiting on other bugs in the stack before landing

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8ec86e0a33b
AsyncLengthWaitHelper should be threadsafe, r=asuth

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a15de342dab9
AsyncLengthWaitHelper should be threadsafe, r=asuth

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a15de342dab9

Comment 7

[Norisz Fay [:noriszfay]]

Backed out as they were linked to the backed out Bug 1754004

Backout link

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4abc98ed6b99
AsyncLengthWaitHelper should be threadsafe, r=asuth

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 22 changesets (Bug 1759572, Bug 1759563, Bug 1754004, Bug 1754031, Bug 1759569, Bug 1696894) for causing multiple failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=BQ_9eKb_QtqAQRgYOoHw2g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d69647a725a1c4f4dcf6a1460ac9c32a56e7f2ad

Log: https://treeherder.mozilla.org/logviewer?job_id=377070975&repo=autoland&lineNumber=3645
https://treeherder.mozilla.org/logviewer?job_id=377069392&repo=autoland&lineNumber=3841
https://treeherder.mozilla.org/logviewer?job_id=377068595&repo=autoland&lineNumber=4833
https://treeherder.mozilla.org/logviewer?job_id=377071130&repo=autoland&lineNumber=2287
https://treeherder.mozilla.org/logviewer?job_id=377070617&repo=autoland&lineNumber=8173
https://treeherder.mozilla.org/logviewer?job_id=377068816&repo=autoland&lineNumber=37681
https://treeherder.mozilla.org/logviewer?job_id=377070241&repo=autoland&lineNumber=9079

Backout: https://hg.mozilla.org/integration/autoland/rev/36e3802d69934bed836ce1131d2de0fcb97984ae

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b24b561698c
AsyncLengthWaitHelper should be threadsafe, r=asuth

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 22 changesets (Bug 1696894, Bug 1759569, Bug 1754031, Bug 1759563, Bug 1759572, Bug 1754004) for causing leack failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=673ecd5337e13d3bac175a1f405862955f14002d&selectedTaskRun=bTfZ8n03SnKvj49Rus408A.0

Log: https://treeherder.mozilla.org/logviewer?job_id=377632893&repo=autoland&lineNumber=7392
https://treeherder.mozilla.org/logviewer?job_id=377629411&repo=autoland&lineNumber=32257

Backout: https://hg.mozilla.org/integration/autoland/rev/ce1bb7d083b9428f4a0985216baddd883c54e62a

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83e2d1f0a115
AsyncLengthWaitHelper should be threadsafe, r=asuth

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/83e2d1f0a115