1759911 - Exception... "Could not convert JavaScript argument arg 4 [nsIWebBrowserPersist.savePrivacyAwareURI]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS) after attempting to Save Page As on View Source window.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Lasana Murray]

STR:

1. Open a message.
2. Click More > View Source.
3. In the View Source Window, click File > Save Page As
4. Wait for the dialog to come up and attempt to save the page.

Expected Result:
The contents of the message should be saved wherever you specified.

Actual Result:
Nothing saves, error is thrown in the console.

 [Exception... "Could not convert JavaScript argument arg 4 [nsIWebBrowserPersist.savePrivacyAwareURI]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: chrome://global/content/contentAreaUtils.js :: internalPersist :: line 497"  data: no] contentAreaUtils.js:497:13
    internalPersist chrome://global/content/contentAreaUtils.js:497
    continueSave chrome://global/content/contentAreaUtils.js:387
    internalSave chrome://global/content/contentAreaUtils.js:335

Comment 1

[Magnus Melin [:mkmelin]]

Looks like the cookiejar settings param is missing (we're trying to pass the document as cookiejarsettings). https://searchfox.org/comm-central/rev/99fb01a74eff1dae4430bd3b41a4c25abbb09708/mail/base/content/viewSource.js#128

Comment 2

[Lasana Murray]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Looks like the cookiejar settings param is missing (we're trying to pass the document as cookiejarsettings). https://searchfox.org/comm-central/rev/99fb01a74eff1dae4430bd3b41a4c25abbb09708/mail/base/content/viewSource.js#128

Thanks, I was confused looking at the nsIWebBrowserPersist.idl signature.

Comment 3

[Lasana Murray]

Attachment: Bug 1759911 - Add missing cookieJarSettings parameter to internalSave. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/31042e4016bf
Add missing cookieJarSettings parameter to internalSave. r=mkmelin