176131 - Folders disappear when re-filing bookmark folder in its own child

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Eric Liga]

Behavior seen on: Win2k using Mozilla build 2002102208
Talkback Incident ID: TB12940190X

Steps to Reproduce:

1.  Open Bookmark Manager
2.  Create New Folder ("Folder A")
3.  Create New Folder ("Folder B") as a child of Folder A
4.  Toss a bookmark into "Folder B" 
5.  Select "Folder A"
6.  Bring up right-click menu for "Folder A" and choose "File Bookmark(s)..."
(or choose "File Bookmark(s) from the "Edit" menu.
7.  Choose "Folder B" to be "Folder A"'s new parent in the dialog that pops up.

Expected Result: 
  Well, there could be any number of valid responses.  A message telling you
that you can't do that would be fine.  Heck, even just failing to do anything is
probably fine (that's how it currently handles *dragging* a folder into its own
child.

Actual Result:
  Crash.  (See talkback ID above)

Note 1:

If you reproduce the above step, but omit step 4, you get the classic Infocom
2-container bug:  Put container 1 into container 2 then put container 2 into
container 1... both containers disappear from the game.  In this case both
folders disappear from the list.

Note 2:

I'll admit that this isn't something that a healthy mind would attempt to do-- I
was poking around trying to find problems.  But it is a crash, so it's probably
worth fixing.

Comment 1

[Chris Lyon]

*** This bug has been marked as a duplicate of 97424 ***

Comment 2

[Eric Liga]

Bug 97424 (which this bug was marked as a dupe for) seems to be patched and no
longer a problem (I can't reproduce it now) although oddly not closed.  This
bug, however, must be distinct because it's still a problem.  It's worth noting,
however, that the *crash* no longer happens, only the infocom-style
container-in-container problem (where both folders disappear).

Can reproduce this problem (with the above caveat) in Build 2003011604 under Win2k.

Comment 3

[Chris Lyon]

Tweaking summary based on reporter's last comment

Comment 4

[R.K.Aa.]

This is also commented about in bug 191888:

"The second time I tried to open the Personal Toolbar Folder, Mozilla crashed
and all my bookmarks except the Personal Toolbar Folder without the child
Personal Toolbar Folder were missing (deleted)."

Comment 5

[Eric Liga]

Confirmed in 1.3 Final under Win2K (for disappearing folders, not a crash)

Comment 6

[Chris Lyon]

*** Bug 178625 has been marked as a duplicate of this bug. ***

Comment 7

[wacheo]

this bug seems to be fixed by bug 160019.
works on linux trunk build 2003040122.

resolving as fixed.