1762574 - Picture-in-Picture Support for HBOMAX

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[mihaita.banica14]

Steps to reproduce:

Open Picture-in-Picture Window For HBOMAX

Actual results:

Picture-in-Picture Subtitles Don't Work For HBOMAX

Expected results:

Picture-in-Picture Subtitles Work For HBOMAX

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Picture-in-Picture' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Ania]

PiP subtitles are currently supported in Nightly on Youtube, Netflix, and Prime Video + all the websites that support WebVTT format.

Supporting subtitles on HBOMAX would be an enhancement.

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1762574 - PiP support for HBO Max. r=#pip-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4909167a9bca
PiP support for HBO Max. r=pip-reviewers,mhowell

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4909167a9bca

Comment 6

[Ina Popescu, Desktop QA]

Attachment: 2022-06-22_12h08_48.png

Comment 7

[Ina Popescu, Desktop QA]

The subtitles are no longer displayed on HBO MAX while using the latest Nightly 103.0a1.

Comment 8

[Niklas Baumgardner [:niklas]]

Sorry for the confusion.
I wasn't able to get subtitles working on HBOMax. This patch only fixed the play/pause and mute/unmute issues.

Comment 9

[Molly Howell (she/her) (mostly inactive)]

Let's file a separate bug for just subtitles, so we can prioritize that specific enhancement on its own.

Comment 10

[Daniel Bodea [:danibodea]]

(In reply to Niklas Baumgardner [:niklas] from comment #8)

Sorry for the confusion.
I wasn't able to get subtitles working on HBOMax. This patch only fixed the play/pause and mute/unmute issues.

Which steps to reproduce should I use to verify this implementation? Thanks.

Comment 11

[Niklas Baumgardner [:niklas]]

Muting and unmuting in the PiP window and closing, you should no longer need to refresh the page. Also play/pause should always be in sync.

Comment 12

[Donal Meehan [:dmeehan]]

Setting 103 to fixed, based on comment 8