1759192 - When the user mutes a Hulu video in PiP and closes it, he cannot reactivate sound from the main window/player

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user launches a Hulu video in PiP, then mutes it from PiP controls and closes it (or unPiPs), he will notice that the sound can not be reactivated from the main window/player.

Affected versions

• Nightly v99.0a1

Affected platforms

• Confirmed on Windows 10 and Mac 11

Steps to reproduce

1. Launch browser.
2. Be in the US or use a VNP set to US
3. Load Hulu and log in
4. Play a video
5. PiP
6. Mute in PiP
7. Close the PiP window or unPiP
8. Attempt to unmute from the man window/player.

Expected result

• The user can unmute the video from the main player.

Actual result

• The user cannot unmute the video from the main player. Only by reopening the PiP and unmuting from there.

Regression range

• Not a recent regression.

Additional notes

• Another scenario would be: If the user plays a Hulu video, mutes from the main window/player and then launches PiP, he will notice that he cannot unmute the sound from the PiP (appears to be unmuted).

Comment 1

[Daniel Bodea [:danibodea]]

This issue also occurs in the case of HBO Max:

Note

• When the user logs into HBOMAX, plays a video, launches the PiP, clicks the "mute" button and closes the PiP, he will notice that the player cannot be unmuted.

Steps to reproduce

1. Launch browser.
2. Make sure the following prefs are activated:
   media.videocontrols.picture-in-picture.audio-toggle.enabled = TRUE
   media.videocontrols.picture-in-picture.display-text-tracks.enabled = TRUE
3. Set VPN to US and activate.
4. Log into https://www.hbomax.com/
5. Play a video and launch the PiP.
6. Click the PiP's "sound" button (to mute video).
7. Click any of the PiP "closing" buttons.

Expected result

• The PiP is closed and the sound can be reactivated from the original player.

Actual result

• The PiP is closed, but the sound can NOT be reactivated from the original player.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

As with bug 1762574, we'd probably need a site-specific wrapper for HBO here to make sure the site is made aware of the changing mute state.

Comment 3

[Daniel Bodea [:danibodea]]

This issue can also be observed in videos of EDX

Comment 4

[Daniel Bodea [:danibodea]]

This issue also occurs in the case of BBC videos on all platforms (ex).

Comment 5

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1759192 - Site wrapper for Hulu. r=#pip-reviewers!

Comment 6

[Ina Popescu, Desktop QA]

This issue occurs also on ici.radio-canada.ca(e.g. https://ici.radio-canada.ca/info/videos/media-8558777/140-spas-veulent-rouvrir).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30a69a229ac2
Site wrapper for Hulu. r=pip-reviewers,mhowell

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/30a69a229ac2

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Peter Magyari (Desktop QA)]

The issue is still reproducible on Nightly 103.0a1 (20220531065724) both on MacOS and Windows.

Comment 11

[Niklas Baumgardner [:niklas]]

(In reply to Peter_M from comment #10)

The issue is still reproducible on Nightly 103.0a1 (20220531065724) both on MacOS and Windows.

For Hulu or HBO Max? The patch on this bug only fixes Hulu.
HBO Max support is bug 1762574

Comment 12

[Peter Magyari (Desktop QA)]

It has indeed fixed the issue on Hulu.

However, the issue still occurs on BBC videos, Radio-Canada as well as HBO Max.

Comment 13

[Daniel Bodea [:danibodea]]

Hey @Niklas: Do you think we should log another bug for the remaining streaming services or a separate one for each?

Comment 14

[Niklas Baumgardner [:niklas]]

Please do a separate bug for each streaming service. Thanks!

Comment 15

[Daniel Bodea [:danibodea]]

As requested in comment 14, I've logged separate bugs for each streaming service that shows this behavior: bug 1775529, bug 1775534, and bug 1775539.

Comment 16

[Daniel Bodea [:danibodea]]

According to comment 12 and with the retesting of Nightly v103.0a1, I can confirm the fix in Hulu (only).