1762752 - "error: there is no argument named `arg` in geckodriver" with rustc 1.57.0

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P2)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:

1. set rustc 1.57.0 as default
2. ./mach build on revision 3a5752d614cea0d0a2d1edaff6cc80eb369584a5, without mozconfig file, on Windows

Actual result:

 5:25.35 error: there is no argument named `arg`
 5:25.35    --> testing\geckodriver\src\capabilities.rs:485:39
 5:25.35     |
 5:25.35 485 |                     format!("Argument {arg} can't be set via capabilities"),
 5:25.35     |                                       ^^^^^
 5:26.87 error: could not compile `geckodriver` due to previous error
 5:26.88 mozmake[4]: *** [C:/mozilla-source/mozilla-unified/config/makefiles/rust.mk:490: force-cargo-program-build] Error 101
 5:26.89 mozmake[3]: *** [C:/mozilla-source/mozilla-unified/config/recurse.mk:72: testing/geckodriver/target] Error 2
 5:26.89 mozmake[3]: *** Waiting for unfinished jobs....

Capturing the argument from the scope is available from rustc 1.58.0, and the current minimum version is 1.57.0

https://searchfox.org/mozilla-central/rev/1f263e9a1f56106f18002bcd9715709007fa7f36/python/mozboot/mozboot/util.py#26

MINIMUM_RUST_VERSION = "1.57.0"

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:whimboo, since you are the author of the regressor, bug 1759994, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Kai Engert (:KaiE:)]

meetoo

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sorry, didn't know that there is such a minimum Rust version setting. Will have a patch in a moment.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1762752 - [geckodriver] Don't use named argument when formatting a message as long as minimum supported Rust version is 1.57.0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eb17d0385df
[geckodriver] Don't use named argument when formatting a message as long as minimum supported Rust version is 1.57.0 r=webdriver-reviewers,jdescottes

Comment 7

[Masatoshi Kimura [:emk]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #4)

Sorry, didn't know that there is such a minimum Rust version setting. Will have a patch in a moment.

Another option is updating the minimum rustc version requirement. See bug 1744234 for example.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Masatoshi Kimura [:emk] from comment #7)

Another option is updating the minimum rustc version requirement. See bug 1744234 for example.

Sure, but I would leave this actually to Firefox Build System peers given that such a forced minimum version upgrade could cause compiler issues with Rust as well. And fixing other code is not actually something that I have the time for. But thanks for hinting!

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1eb17d0385df

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The consequences of this bug is that folks on Windows have issues to build Firefox even it's testing only related. It regressed for Firefox 100 and as such the patch needs to be uplifted to beta. Can someone please do so? Thanks.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/251a74f6b63a

Comment 12

[Masatoshi Kimura [:emk]]

The minimum Rust requirement has been updated to 1.59 after all. (bug 1763305)