1763464 - Dragging bookmarked items from the overflow menu onto the current opened webpage breaks the drag functionality

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[wardz]

Steps to reproduce:

1. Configure the bookmarks toolbar to only show on new empty tab. (Important)
2. Create enough bookmarks so it overflows your bookmarks toolbar to the right.
3. Drag any item from the overflow menu onto the current webpage/tab/location bar so it opens the site.
4. Open a new empty tab. (Important)
5. Try to drag any item from the overflow menu. It won't work, but bookmarks outside the overflow can still be dragged.

This issue seems to happen for both Windows 11 and latest MacOS.

Actual results:

I can't drag the overflowed bookmarks anywhere unless I restart the browser.

Expected results:

I should be able to drag these.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Brindusa Tot, Desktop QA]

Seems to be similar with bug 1761877. Please reopen if you don't agree.

Comment 4

[wardz]

This bug is not related to wayland as it happens on both mac and windows. It's also not specific to dragging towards the toolbar, but to anywhere on the page. It also seems to trigger only with bookmark bar "Only Show On New Tab" enabled.

Comment 5

[Mark Banner (:standard8)]

I can reproduce this. It looks like the view controller isn't hooked up properly for the second tab:

15:26:58.660 Uncaught TypeError: can't access property "canMoveNode", this._rootView.controller is null
    on_dragstart chrome://browser/content/places/places-menupopup.js:409
    handleEvent chrome://global/content/customElements.js:466
4 places-menupopup.js:409:11

Comment 7

[Mark Banner (:standard8)]

This seems to work for me and a few other people now. Closing it out.

Comment 8

[wardz]

Still reproducible everytime for me on both Windows 11 and macOS Sonoma with a fresh install of latest Firefox.
Do I need to build firefox in debug mode or something to view error logs, or can I view them a quicker way?

Comment 9

[wardz]

(In reply to Mark Banner (:standard8) from comment #7)

This seems to work for me and a few other people now. Closing it out.

Nevermind previous comment, figured it out. It's giving me this error when I try to drag the bookmark item:

places-menupopup.js:433:11

Uncaught TypeError: this._rootView.controller is null
    on_dragstart chrome://browser/content/places/places-menupopup.js:433
    handleEvent chrome://global/content/customElements.js:459

Comment 10

[wardz]

fyi mozregression shows me build 2020-10-25 is the last working one, but its unable to provide more details when bisecting.

Comment 11

[wardz]

This is now happening in the Tor browser aswell after the 13.0 update.

Comment 12

[Stephanie Cunnane [:scunnane]]

We may have a problem where the bookmark toolbar gets out of sync with the UI (possibly the bookmarks toolbar gets gc'd).

Comment 13

[wardz]

PS: not sure if this matters, but im on the norwegian x64 nb-NO firefox version.

Comment 14

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1763464: Use available bookmark toolbar in places-menupopup

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d44ba967d765
Use available bookmark toolbar in places-menupopup r=places-reviewers,Standard8

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d44ba967d765

Comment 17

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-06-10 Nightly build on Windows 10.
Verified as fixed on Firefox 129.0b5 and Firefox Nightly 130.0a1 on Windows 10, Ubuntu 22, macOS 14.