1800475 - Customization breaks Drag&Drop (maybe more) in the Bookmarks Toolbar overflow menu

Status: NEW

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Marco Bonardo [:mak]]

After customization DND in the Bookmarks Toolbar chevron menu doesn't work anymore, this is usually a symptom of a zombie widget that should be recreated (or at least in the past that used to happen, indeed we uninit all the views).
STR:

1. Show the bookmarks toolbar always if necessary
2. Open the Library, go to the Toolbar root, duplicate the default Get Involved bookmark until the toolbar overflows. Close the Library
3. Check drag&drop in the toolbar overflow chevron menu works
4. open Customization, and close it
5. try again to drag&drop in the toolbar overflow chevron menu

ER:
DND continues working
AR:
DND is broken

This is the regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8dd0375cfaf81d140c19c98f8a9dda28b9a201c1&tochange=3afb892abb74c6d281f3e66431408cbb2e16b8c4
Unfortunately it's old builds so it cannot be restricted further, though I suspect Bug 1539651

Comment 1

[Alice0775 White]

I confirmed the regression range from local cached build.
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8bd696e50a12db4f6be4ded519ef4f97ed6fed60&tochange=bd7cd9d7b6ade7bf9fa8441a8686f19c36f2a7e5

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:surkov, since you are the author of the regressor, bug 1539651, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1539651

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Surkov is inactive. Redirecting the NI to mak for now as the reviewer of the regressing change, but feel free to redirect as needed.

Comment 5

[Marco Bonardo [:mak]]

This needs normal debugging, it's hard to tell what went wrong in the original patch being a conversion from xul.
Someone (maybe me, but I'm not working on this bug atm) should debug why on customizeDone the widget is not in a usable way... as I said in comment 0 we uninit the Places view on customize start, and will be recreated on popupshowing... though there may be more.