1842288 - After once reordered bookmarks in the chevron popup, toggling Bookmarks Toolbar from hidden to visible disables reordering of bookmarks in the chevron by mouse dragging.

Status: NEW

(Firefox :: Bookmarks & History, defect, P2)

Description

[Matteo]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

(only possible if you have more than 15/16 bookmarked websites-also I enabled option that only shows bookmark toolbar in new tabs) open firefox > go to the show more bookmarks > open one of the bookmarked website > open again bookmarks toolbar "show more bookmarks" > try to reorder websites there and reordering does not happen

Actual results:

not possible to reorder websites manually in the bookmark toolbar when there are visible under "show more bookmarks". it's possible to reorder them only if they are in a folder.

Expected results:

I should be able to reorder websites like I can do when they are in the bookmarks toolbar or inside a folder

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

I can reproduce the issue on Nightly117.0a1 windows10. This is not a recent regression.

After once reordered bookmarks in the chevron, toggling Bookmarks Toolbar from hidden to visible disables reordering of bookmarks in the chevron by mouse dragging.

Steps to reproduce:

1. Bookmark many websites in the Bookmarks Toolbar so that the Bookmarks Toolbar will be overflowed.
2. Show Bookmarks Toolbar
3. Reorder bookmarks in the chevron(>>) by mouse drag
4. Hide Bookmarks Toolbar
5. Show Bookmarks Toolbar again
6. Try reorder bookmarks in the chevron by mouse drag

An error is shown in the browser console.

Uncaught TypeError: can't access property "canMoveNode", this._rootView.controller is null
    on_dragstart chrome://browser/content/places/places-menupopup.js:433
    handleEvent chrome://global/content/customElements.js:459
places-menupopup.js:433:11
    on_dragstart chrome://browser/content/places/places-menupopup.js:433
    handleEvent chrome://global/content/customElements.js:459

Comment 3

[Marco Bonardo [:mak]]

it sounds like the view is not destroyed and recreated correctly.

Comment 4

[Matteo]

It seems that this bug does not happen if you set Bookmarks Toolbar to "Always show" and restart Firefox. I hope this is useful.

Comment 6

[Daisuke Akatsuka (:daisuke)]

It seems that this bug's cause is the same as bug 1763464.
After fixing that bug, let's confirm, just to be safe.