1763470 - Accessibility updates for FX100 upgrade dialog

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Meg Viar [:mviar]]

• The animated logo is not disabled when a user has prefers-reduced-motion enabled
• The title text becomes invisible for high-contrast black themes, difficult to read on other high contrast dark themes
• Hitting tab initially focuses "not now" instead of the preferred "pin" button

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:tspurway, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1763470 - Accessibility updates for FX100 upgrade dialog

Comment 3

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Accessibility issues for upgrade spotlight shown to all users upgrading to 100

Comment 4

[Ed Lee :Mardak]

Bug 1708261 is for the hidden focus ring for the primary button already focused where the ring only appears after tabbing to "not now"

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59868a572cb6
Accessibility updates for FX100 upgrade dialog r=Mardak

Comment 6

[Meg Viar [:mviar]]

Comment on attachment 9271297 [details]
Bug 1763470 - Accessibility updates for FX100 upgrade dialog

Beta/Release Uplift Approval Request

• User impact if declined: Users with dark themes in high contrast mode with dark or black themes may be unable to read the promo title. Users who prefer reduced motion may still see an animated heart logo.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

1. configure to show upgrade spotlight (browser.startup.homepage_override.mstone set to "99", browser.startup.upgradeDialog.version set to 94)
2. restart Firefox
3. Using high contrast mode with a dark or black theme, confirm that title text is visible with ample contrast. After setting a preference to reduce motion, confirm that the heart animation changes to a static heart image.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We're limiting our changes to CSS updates and the addition of a new image asset.
• String changes made/needed: None

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/59868a572cb6

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 101.0a1 (Build ID: 20220408094506) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

• The heart logo is not animated when a user has prefers-reduced-motion enabled.
• The primary button from the “Thank you” spotlight is focused first when navigating with keyboard navigation through the spotlight.
• The title text is visible when a High Contrast Black theme is enabled.

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9271297 [details]
Bug 1763470 - Accessibility updates for FX100 upgrade dialog

Approved for 100.0b4

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/193885f45f61

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using Firefox Beta 100.0b6 (Build ID: 20220414190112) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

• The heart logo is not animated when a user has prefers-reduced-motion enabled.
• The primary button from the “Thank you” spotlight is focused first when navigating with keyboard navigation through the spotlight.
• The title text is visible when a High Contrast Black theme is enabled.