1763832 - Discord broken: Chromium users can't see&hear me talk

Status: VERIFIED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Darkspirit]

Attachment: 2022-04-08_18-04-06.mp4

Debian Testing, Gnome Wayland, Intel Macbook Pro

After joining the channel, others users (Chromium) see me shortly green as if I was talking for a part of a second.
After this, no one sees or hears me talking.

mozregression --good 2022-04-04 --bad 2022-04-06 -a https://discord.gg/xxxxxxxxxxxxxx

26:24.91 INFO: Last good revision: 056457fa52febdeee37b554ce563ecd0b4f336ae
26:24.91 INFO: First bad revision: f853e1e31b3862bcb514005accfd7405ece5225d
26:24.91 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=056457fa52febdeee37b554ce563ecd0b4f336ae&tochange=f853e1e31b3862bcb514005accfd7405ece5225d

f853e1e31b3862bcb514005accfd7405ece5225d Byron Campen — Bug 1616937: Fix some warnings from clang-tidy on pre-existing code. r=mjf
6908b674bc94430e1956cf66049f0ec6e4f4310f Byron Campen — Bug 1616937: Move some sender and receiver logic to RTCRtpSender/Receiver. r=mjf
91a1718d9a5a57f6660d2eb350eb9eff6619567a Byron Campen — Bug 1616937: Improve error handling during conduit updates. r=mjf
f045541b25753d63f5e05177697263a7bd2d9727 Byron Campen — Bug 1616937: Hold strong refs to the PC in Transceiver/Sender/Receiver. r=mjf
41ff3e562389dc586985302c710f034f13f5dd74 Byron Campen — Bug 1616937: Remove main thread parameters/members. r=mjf
31d4e8adf1dc76bab13e45ef3ba578651744232e Byron Campen — Bug 1616937: Move RTCRtpSender to c++ r=mjf,webidl,smaug
235f461a1229a4695210fbcba292ca64140c51f4 Byron Campen — Bug 1624989: Some simplifications that are possible because PeerConnectionImpl is cycle-collected. r=jib
d570e7369906010743035437ff6ff4b4c7a34e67 Byron Campen [:bwc] — Bug 1624989: Move RTCPeerConnection's operations chain to c++ r=jib,webidl,smaug

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

:bwc, since you are the author of the regressor, bug 1616937, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Darkspirit]

Attachment: aboutsupport.txt

Comment 3

[Darkspirit]

Attachment: aboutsupport.json

Comment 4

[Darkspirit]

Profile with Media Preset: https://share.firefox.dev/35SqqzF
made with: mozregression --repo autoland --launch f853e1e31b3862bcb514005accfd7405ece5225d -a https://discord.gg/xxxxxxxxxxxxxx

Comment 5

[Darkspirit]

There is no crash (no Nightly crash report, no Asan Nightly crash report), it just doesn't work.

Comment 6

[Byron Campen [:bwc]]

Could you attach a copy of about:webrtc? I suspect this is a site issue, but not sure about the details.

Comment 7

[Darkspirit]

Attachment: aboutWebrtc.html

mozregression --launch 20220408094506 -a https://discord.com/channels/xxxxxxxx -a about:webrtc

Comment 8

[Darkspirit]

Attachment: aboutWebrtc2.html

Comment 9

[Darkspirit]

The push contained commits from two bugs. Adding the other one.

Comment 10

[Darkspirit]

Attachment: aboutWebrtc_win10.html

Problem also occurs on Win10.

Comment 11

[Darkspirit]

Attachment: aboutsupport_win10.txt

Comment 12

[Byron Campen [:bwc]]

I'm seeing multiple problems here. For some reason, discord stopped putting ssrc attributes in its SDP, has apparently never supported the RTP MID extension, and uses multiple bundled audio m-sections with the same payload type. This can never work; it is impossible to determine what m-section an incoming RTP packet belongs to.

Comment 13

[Byron Campen [:bwc]]

Actually, it is worse than this; the audio m-section provided in the remote SDP is recvonly. If discord is saying that it is not going to send any data, of course we won't be receiving any...

Comment 14

[Darkspirit]

Attachment: aboutWebrtc_lastgood_linux.html

about:webrtc from last good autoland build:
mozregression --repo autoland --launch 056457fa52febdeee37b554ce563ecd0b4f336ae -a https://discord.gg/xxxxxxx -a about:webrtc

Comment 15

[Darkspirit]

Attachment: aboutWebrtc_firstbad_linux.html

about:webrtc from first bad autoland build:
mozregression --repo autoland --launch f853e1e31b3862bcb514005accfd7405ece5225d -a https://discord.gg/xxxxxxxx -a about:webrtc

Comment 16

[Byron Campen [:bwc]]

Ok, this is really weird. Minutes after joining the room, discord decided to renegotiate. Now it seems to be negotiating properly? This inconsistent operation is making it really hard to figure out what is going on.

Comment 17

[Byron Campen [:bwc]]

Ok, now that I have some baseline functionality, I think I see the problem. Running a fix through its paces.

Comment 18

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f0dfc9807b7e162720f42f7e9f609786aecdbac
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc31564c8f2149f2a1d912523239ba0524e914c4

Comment 19

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=30d469cde1fcd7f3e8e3739bc449db1c673bf8cd
https://treeherder.mozilla.org/jobs?repo=try&revision=3657b03a31b3607353bf12d95fc8ae31f42d436f

Comment 20

[Byron Campen [:bwc]]

Ok, got android working now:

https://treeherder.mozilla.org/jobs?repo=try&revision=eddb069ca4a1a38d26648505a6e83cfcfbc7e39e

Try looks ok.

Comment 21

[Byron Campen [:bwc]]

Attachment: Bug 1763832: Test-case for bug. r?mjf

Comment 22

[Byron Campen [:bwc]]

Attachment: Bug 1763832: Make sure we update the pipeline track even when not sending. r?mjf

Depends on D143494

Comment 23

[Byron Campen [:bwc]]

Patches resolve the issue for me, can you check that the try build works for you as well?

Comment 24

[Darkspirit]

Attachment: aboutWebrtc_try_good.html

Debian Testing, Gnome Wayland, Intel Macbook Pro

Today's Nightly 20220412094307 is still broken.

The try build is good/fixed. Thanks!
mozregression --repo try --launch eddb069ca4a1a38d26648505a6e83cfcfbc7e39e -a https://discord.com/invite/xxxxxxx -a about:webrtc

Comment 25

[Byron Campen [:bwc]]

Awesome, thanks for the bug report and the verification!

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcd802d2e400
Test-case for bug. r=mjf
https://hg.mozilla.org/integration/autoland/rev/e475c8d65a8d
Make sure we update the pipeline track even when not sending. r=mjf

Comment 28

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/fcd802d2e400
https://hg.mozilla.org/mozilla-central/rev/e475c8d65a8d

Comment 29

[Ardelean Oana]

I managed to reproduce the issue on a 2022-04-08 Nightly build on macOS 11. Verified as fixed on Nightly 102.0a1(20220516215740) and Firefox 101.0b7(20220515185854) on Win10, Ubuntu 20.04, macOS 11.